Skip to content

Conversation

@congcongke
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it

In my opinion, the replica should be decreased when the (unready replica < maxSurge). It means the rolling update is in progress and newly created one is partly stable.

Which issue(s) this PR fixes

Background:

  1. LWS is in running with 1 replica, 25% maxSurge and 25% minUnavailable
  2. Update the image or cpu quota of LWS

What I want:

  1. Scale Statefulset up to 2 replica, with the second instance with new image.
  2. After the second one is in running, update the first instance
  3. Scale Statefulset down to 1 replica, with all the instance updated

Actual

  1. The replica of Statefulset is stay at 1 with partition is set to 1

Special notes for your reviewer

Does this PR introduce a user-facing change?


@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 7, 2025
@k8s-ci-robot k8s-ci-robot requested a review from ardaguclu April 7, 2025 12:32
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: congcongke
Once this PR has been reviewed and has the lgtm label, please assign edwinhr716 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from yankay April 7, 2025 12:32
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 7, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @congcongke. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@netlify
Copy link

netlify bot commented Apr 7, 2025

Deploy Preview for kubernetes-sigs-lws canceled.

Name Link
🔨 Latest commit 4b749ac
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-lws/deploys/6819c71bacc47c00088e9ecf

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 7, 2025
@Edwinhr716
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 7, 2025
@congcongke congcongke force-pushed the update-fix branch 2 times, most recently from 74d4113 to 994ab07 Compare April 8, 2025 13:40
@congcongke congcongke changed the title fix: don't release the burst replica until the unreadyReplicas less than maxSurge fix: support rolling update lws with 1 replica May 6, 2025
@kerthcet
Copy link
Contributor

What's the status here? @Edwinhr716

@Edwinhr716
Copy link
Contributor

Only saw the duplication of tests, haven't really taken a look at it or thought about if it is something we want

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2025
@k8s-ci-robot
Copy link
Contributor

@congcongke: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-lws-test-e2e-main-gang-scheduling 4b749ac link true /test pull-lws-test-e2e-main-gang-scheduling
pull-lws-test-e2e-main-1-33 4b749ac link true /test pull-lws-test-e2e-main-1-33

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants