Skip to content

Conversation

@zhouzhifeisdcn
Copy link

Do not automatically create PG,when pod not use schedule volcano
fixed issue #630

Do not automatically create PG when pod not used schedule volcano
@netlify
Copy link

netlify bot commented Aug 27, 2025

Deploy Preview for kubernetes-sigs-lws canceled.

Name Link
🔨 Latest commit 96e76dc
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-lws/deploys/68aebd961cce2f0008dbba46

@linux-foundation-easycla
Copy link

CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhouzhifeisdcn
Once this PR has been reviewed and has the lgtm label, please assign edwinhr716 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from ahg-g and kerthcet August 27, 2025 08:11
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @zhouzhifeisdcn. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 27, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Aug 27, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 27, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Aug 27, 2025

can we please add tests to cover this?

@k8s-ci-robot
Copy link
Contributor

@zhouzhifeisdcn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-lws-test-unit-main 96e76dc link true /test pull-lws-test-unit-main
pull-lws-test-integration-main 96e76dc link true /test pull-lws-test-integration-main
pull-lws-test-e2e-main-1-32 96e76dc link true /test pull-lws-test-e2e-main-1-32
pull-lws-test-e2e-main-1-31 96e76dc link true /test pull-lws-test-e2e-main-1-31
pull-lws-test-e2e-main-1-30 96e76dc link true /test pull-lws-test-e2e-main-1-30
pull-lws-test-e2e-main-cert-manager 96e76dc link true /test pull-lws-test-e2e-main-cert-manager
pull-lws-test-e2e-main-gang-scheduling 96e76dc link true /test pull-lws-test-e2e-main-gang-scheduling
pull-lws-verify-main 96e76dc link true /test pull-lws-verify-main
pull-lws-test-e2e-main-1-33 96e76dc link true /test pull-lws-test-e2e-main-1-33

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

}

if r.SchedulerProvider != nil {
if r.SchedulerProvider != nil && strings.Contains(pod.Spec.SchedulerName, string(schedulerprovider.Volcano)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a good choice to hard-code it here, I think the main reason in your issue is that, volcano will automatically create podgroups for orphan pods, but you didn't specify schedulerName: volcano in your lws template. I think we'd better automatically inject schedulerName: volcano for lws needs to use volcano as the gang scheduler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants