feature: adding support for force delete into azure

[MaximilianoUribe]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adding force delete support into azure to solve issues with autoscaler not deleting failed nodes when at mincount.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Enables the possibility to use ForceDeleteFailedNodes for cases when failed nodes need to be deleted when at mincount.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MaximilianoUribe
Once this PR has been reviewed and has the lgtm label, please assign nilo19 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• cluster-autoscaler/cloudprovider/azure/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @MaximilianoUribe. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jackfrancis]

/ok-to-test

[Bryce-Soghigian]

Can we add unit tests that tests

MinCount: 1
LongUnregisteredCount: 1
RegisteredCount: 0

Without force delete this test should fail, but with it introduced it should pass.

[Bryce-Soghigian]

There are two flags in cluster-autoscaler/config/autoscaling_options.go.

1. ForceDeleteLongUnregisteredNodes
2. ForceDeleteFailedNodes

Can we write unit tests that validate when set we are properly removing vms with force delete we otherwise wouldn't?

[Bryce-Soghigian]

how are these annotations used?

[rakechill]

@MaximilianoUribe did you get a chance to look into this?