refact/lb/sg: isolate security group deletion fragments from EnsureLoadBalancerDeleted

[mtulio]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Isolating security group deletion fragments from EnsureLoadBalancerDeleted to buildSecurityGroupsToDelete and deleteSecurityGroupsWithBackoff, so the evaluation criteria and backoff deletion can be reused in future implementations, i.e. NLB with Security Groups.

This change contributes to decrease the change scope of #1158.

Only the backoff logic has been changed to add exponencial check, preventing

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[k8s-ci-robot]

Hi @mtulio. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mtulio]

PTAL? This change is making the code more generic to be used in future implementations, such as #1158
/assign @kmala @elmiko

[elmiko]

probably won't get to this today, but i will review early next week.

[mtulio]

I am able to run the tests locally:

$ make test
....
    --- PASS: TestGetNodeTopology/Should_return_unhandled_errors (0.00s)
PASS
ok  	k8s.io/cloud-provider-aws/pkg/resourcemanagers	1.025s
?   	k8s.io/cloud-provider-aws/pkg/services	[no test files]


$ ./e2e.test --ginkgo.v
....
-----------------------------

Summarizing 1 Failure:
  [FAIL] [cloud-provider-aws-e2e] ecr [It] should start pod using public ecr image
  /home/mtulio/go/pkg/mod/k8s.io/[email protected]/test/e2e/framework/pod/pod_client.go:107

Ran 6 of 6 Specs in 710.314 seconds
FAIL! -- 5 Passed | 1 Failed | 0 Pending | 0 Skipped
--- FAIL: TestE2E (710.31s)
    suite_test.go:46: ReportDir: 
FAIL

Looks like the failed one would be related with my local setup, needs label ok-to-test to validate it in controlled environment.

[yue9944882]

/ok-to-test

[mtulio]

I am observing a permanent failure on CI when launching the cluster trying to use an image that is no longer available:
https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/cloud-provider-aws/1159/pull-cloud-provider-aws-e2e/1934643492319924224#1:build-log.txt%3A752

 specified image "099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20250502.1" is invalid: could not find Image for "099720109477/ubuntu/images/hvm-ssd-gp3/ubuntu-noble-24.04-amd64-server-20250502.1"

This is also happening in other PRs I am watching.

Is this comes from the test framework or is it possible to use a valid image in CCM repo?

[mtulio]

/test pull-cloud-provider-aws-e2e

[mtulio]

An issue has been opened to track the CI problem: #1167

[mtulio]

Hi @yue9944882 @kmala , feedback addressed. Would you mind taking a look? I am still waiting/looking for CI to fix e2e job (#1167), but this is ready for review.

[mtulio]

/test pull-cloud-provider-aws-e2e

[mtulio]

Looks like e2e is now working, and tests are green awaiting for feedback! Thanks!

[mtulio]

Hey @kmala , feedback addressed. PTAL? Thanks!

[kmala]

/triage accepted
/lgtm

[elmiko]

this makes sense to me, ++ on the code docs too.

/lgtm

[kmala]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kmala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kmala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mtulio]

Hey @kmala @elmiko , thanks a lot for reviewing and approving this PR. Can I have lgtm labels again? it was lost after rebase. thanks!

[kmala]

/lgtm