-
Notifications
You must be signed in to change notification settings - Fork 346
e2e: bump dependencies to more recent k8s lib #1256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue is currently awaiting triage. If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @mtulio. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Updating the test framework to the more recent k8s libraries to incorporate recent improvements as well bug and security fixes.
Local tests are passing: $ ./e2e.test --ginkgo.v --ginkgo.focus 'loadbalancer'
...
Ran 5 of 8 Specs in 804.970 seconds
SUCCESS! -- 5 Passed | 0 Failed | 0 Pending | 3 Skipped
PASS
$ ./e2e.test --ginkgo.v --ginkgo.focus '\[cloud-provider-aws-e2e\] node'
...
Ran 2 of 8 Specs in 3.964 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 6 Skipped
PASS |
Converting to ready to review as testing local are passing in my cluster. Awaiting for required labels to test on presubmit jobs. |
What type of PR is this?
/kind cleanup
/kind failing-test
What this PR does / why we need it:
This change proposes to update the e2e test binary to the more recent k8s dependencies, pinning to the same k8s version, so that test binary is enhanced with bug and security fixes from core, as well features added to the framework, such as moving the network/curl test from ReplicationController to Deployment configuration.
The PR helps on getting on sync as part of the request #1255 to incorporate the bump in the release process.
Which issue(s) this PR fixes:
Relates to #1255
Special notes for your reviewer:
Does this PR introduce a user-facing change?: