Skip to content

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Sep 5, 2025

What type of PR is this?

/kind cleanup
/kind failing-test

What this PR does / why we need it:

This change proposes to update the e2e test binary to the more recent k8s dependencies, pinning to the same k8s version, so that test binary is enhanced with bug and security fixes from core, as well features added to the framework, such as moving the network/curl test from ReplicationController to Deployment configuration.

The PR helps on getting on sync as part of the request #1255 to incorporate the bump in the release process.

Which issue(s) this PR fixes:

Relates to #1255

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mmerkes for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 5, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 5, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @mtulio. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 5, 2025
@mtulio
Copy link
Contributor Author

mtulio commented Sep 5, 2025

Hey @elmiko @kmala , can I have ok-to-test here, please?

Updating the test framework to the more recent k8s libraries to
incorporate recent improvements as well bug and security fixes.
@mtulio
Copy link
Contributor Author

mtulio commented Sep 5, 2025

Local tests are passing:

$ ./e2e.test --ginkgo.v  --ginkgo.focus 'loadbalancer'
...
Ran 5 of 8 Specs in 804.970 seconds
SUCCESS! -- 5 Passed | 0 Failed | 0 Pending | 3 Skipped
PASS

$ ./e2e.test --ginkgo.v  --ginkgo.focus '\[cloud-provider-aws-e2e\] node'
...
Ran 2 of 8 Specs in 3.964 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 6 Skipped
PASS

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 5, 2025
@mtulio mtulio marked this pull request as ready for review September 5, 2025 21:44
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2025
@mtulio
Copy link
Contributor Author

mtulio commented Sep 5, 2025

Converting to ready to review as testing local are passing in my cluster. Awaiting for required labels to test on presubmit jobs.

@mtulio
Copy link
Contributor Author

mtulio commented Sep 5, 2025

/assign @kmala @elmiko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants