KEP-4603: Correct conflict resolution table #5201
Conversation
lauralorenz
commented
Mar 12, 2025
lauralorenz
commented
- One-line PR description: Fix conflict resolution table, during implementation realized a line was incorrect and the prose had conflated initial and max values in a case
- Issue link: Tune CrashLoopBackOff #4603
- Other comments: N/A
…ax value Signed-off-by: Laura Lorenz <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lauralorenz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
sig/node
k8s-ci-robot
added
the
size/S
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
k8s-ci-robot
removed
the
lifecycle/stale
| If on a given node at a given time, the per-node configured maximum backoff is | ||
| higher than the current initial value, but within validation limits as it is | ||
| higher than the default maximum backoff, but within validation limits as it is | ||
| lower than 300s, it will be honored. In other words, operator-invoked | ||
| configuration will have precedence over the default, even if it is slower, as | ||
| configuration for the maximum backoff will have precedence over the default, even if it is slower, as | ||
| long as it is valid. |
There was a problem hiding this comment.
nit: is this paragraph necessary? Isn't this just stating what a default means? Or am I missing something?
There was a problem hiding this comment.
It is, but then so is the first paragraph (ending in "In other words, operator-invoked configuration will have
precedence over the default if it is faster."). I think both paragraphs were to make that explicit, and separately in the event there was appetite for different conflict resolution depending on if a node's default was slower or faster than what the user's crashloopbackoff.maxSeconds requested (though in the end the behavior ended up being the same).
