Skip to content

KEP-4205: Graduate Expose PSI Metrics to GA #5605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

KEP-4205: Graduate Expose PSI Metrics to GA #5605

wants to merge 2 commits into from

Conversation

mariafromano-25
Copy link

@mariafromano-25 mariafromano-25 commented Oct 2, 2025 •
edited
Loading

  • One-line PR description:
    This PR updates KEP-4205 to reflect the graduation of the "Expose PSI Metrics" feature to General Availability (GA), targeting the v1.35 release.
    The KEP stage has been updated to stable and the latest-milestone is now v1.35.
  • Other comments:
    /kind documentation
    /sig node
    /assign @roycaihw

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 2, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @mariafromano-25!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Oct 2, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 2, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @mariafromano-25. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 2, 2025
@kannon92
Copy link
Contributor

kannon92 commented Oct 3, 2025

/ok-to-test

1 similar comment
@kannon92
Copy link
Contributor

kannon92 commented Oct 3, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 3, 2025
@kannon92
Copy link
Contributor

kannon92 commented Oct 3, 2025

Two things:

  1. Please add a prod-readiness file to request a PRR review for this KEP.

  2. We normally avoid promoting features to GA if there are test failures

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mariafromano-25
Once this PR has been reviewed and has the lgtm label, please assign johnbelamaric for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 7, 2025
roycaihw
roycaihw reviewed Oct 7, 2025
View reviewed changes
keps/sig-node/4205-psi-metric/README.md
NOTE: Also set `disable-supported` to `true` or `false` in `kep.yaml`.
-->
Yes
Yes, but starting in v1.35 where this feature graduates to GA, the KubeletPSI feature gate will be locked to true and will no longer be disable-able.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/1.35/1.36

keps/sig-node/4205-psi-metric/kep.yaml
milestone:
alpha: "v1.33"
beta: "v1.34"
stable: "v1.36"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should leave the milestone unchanged. We can update it during the 1.36 cycle. When we update we should confirm that all GA criteria are met.

Either way we will need to update the latest-milestone: "v1.35" line when 1.36 comes.

keps/sig-node/4205-psi-metric/README.md
#### GA
- Gather evidence of real world usage.
- No major issue reported.
- Quantify the cAdvisor and kubelet-level overhead of PSI metric collection, especially where PSI is disabled at the kernel level.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also ensure we cover stress testing scenario. We may need to expand on top of the previous performance benchmarking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@mrunalp mrunalp Awaiting requested review from mrunalp

1 more reviewer

@roycaihw roycaihw roycaihw left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@roycaihw roycaihw

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mariafromano-25 @k8s-ci-robot @kannon92 @roycaihw