-
Notifications
You must be signed in to change notification settings - Fork 1.6k
KEP-4622: promote topologyManager policy: max-allowable-numa-nodes to GA in 1.35 #5627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Cyclinder Kuo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This change is straightforward.
The presubmit check related to the TOC is failing. Please update the TOC, and I’ll add the lgtm
label once that’s done.
Refresh and carry forward PR#5166 Signed-off-by: Francesco Romani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
from sig-node perspective
/assign @SergeyKanzhelev
for node approval
/assign @jpbetz
for PRR review/approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Graduation criteria seems to be met. No Conformance tests required for node-local policy.
did this miss the PRR deadline? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, jpbetz, mrunalp, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
One-line PR description: promote the TopologyManager policy option:
max-allowable-numa-nodes
to GA in 1.35Issue link: KEP-4622: Add a TopologyManager policy option for MaxAllowableNUMANodes #4622
Other comments: