Skip to content

KEP-4762: Promote to beta stage #5636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2025
Merged

KEP-4762: Promote to beta stage #5636

merged 1 commit into from
Oct 16, 2025
+121 −232

Conversation

HirazawaUi
Copy link
Contributor

  • One-line PR description: Promote the HostnameOverride feature gate to beta stage
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 8, 2025
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 8, 2025
@HirazawaUi HirazawaUi mentioned this pull request Oct 8, 2025
Open
8 tasks
soltysh
soltysh reviewed Oct 14, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple PRR beta questions are missing answers.

keps/sig-network/4762-allow-arbitrary-fqdn-as-pod-hostname/README.md

- Add a conformance test to `test/e2e` that verifies our implementation conforms to the expectation defined in the table within the #Design Details section.

### Graduation Criteria
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above:

  • can you explain why no integration tests are added?
  • link to the e2e that you plan to promote to conformance, that's a beta requirement that this functionality have working e2e.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in the graduation criteria, you've mentioned e2e being completed during alpha.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this feature is not particularly complex, I think the e2e tests we've added are sufficient. Moreover, we already have some existing e2e cases related to hostname, and merging them is a natural progression.

I have already added e2e cases during the alpha phase, and I will include them in the KEP.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soltysh we have pretty good coverage between e2e and unit kubernetes/kubernetes#132558 , and since is mostly a node feature integrations will be mostly redundant with the unit for the api validation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust both of you, but it's nice to have it written down in the document, why particular group of tests wasn't added. I see the link to e2e was added, so at least that. But it would be nice to put above explanation into the doc, this can be handled in followup.

@HirazawaUi HirazawaUi force-pushed the promote-4762-to-beta branch from e8c9f20 to 8ac5de9 Compare October 14, 2025 15:09
@aojea
Copy link
Member

aojea commented Oct 15, 2025 •
edited
Loading

/lgtm
/approve

sig network (modulo the standing comments from PRR and the clarifications)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2025
@HirazawaUi HirazawaUi force-pushed the promote-4762-to-beta branch from 8ac5de9 to efe3d81 Compare October 15, 2025 13:52
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2025
SergeyKanzhelev
SergeyKanzhelev approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2025
@HirazawaUi
Copy link
Contributor Author

/assign @deads2k @thockin for approval

@aojea
Copy link
Member

aojea commented Oct 16, 2025

Multiple PRR beta questions are missing answers.

@HirazawaUi you need @soltysh PRR approval

@HirazawaUi
Copy link
Contributor Author

@HirazawaUi you need @soltysh PRR approval

Ah, thank you for the reminder. I'm responsible for multiple KEPs in this cycle and got confused. I mistakenly thought this KEP had already received PRR approval.

soltysh
soltysh approved these changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
the PRR section

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, HirazawaUi, SergeyKanzhelev, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2025
@k8s-ci-robot k8s-ci-robot merged commit 84d890e into kubernetes:master Oct 16, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soltysh soltysh soltysh approved these changes

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@aojea aojea Awaiting requested review from aojea

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees

@aojea aojea

@SergeyKanzhelev SergeyKanzhelev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

5 participants

@HirazawaUi @aojea @k8s-ci-robot @soltysh @SergeyKanzhelev