Skip to content

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Oct 8, 2025

/assign @ardaguclu
for sig-cli review

/assign @deads2k
for PRR review

/hold
so it doesn't merge accidentally before I get both of the above reviews in

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 8, 2025
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Oct 8, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG CLI Oct 8, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 8, 2025
@deads2k
Copy link
Contributor

deads2k commented Oct 8, 2025

it's an older feature. We might have done it differently if we were doing it today, but with this feature already on and no negative impact, this lgtm

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ardaguclu
Copy link
Member

/lgtm
from sig-cli POV

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2025
@soltysh
Copy link
Contributor Author

soltysh commented Oct 9, 2025

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit 11b6321 into kubernetes:master Oct 9, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Oct 9, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG CLI Oct 9, 2025
@soltysh soltysh deleted the headers_stable branch October 9, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants