Update Karpenter to v1.6.2 #17567

hakman · 2025-08-18T19:53:39Z

Iterating on updated Karpenter setup.
Includes:

storing a copy of the startup script that can be used later by kops-controller to generate the EC2NodeClass
disabling LaunchTemplate generation, which can no longer be used by Karpenter.

/cc @rifelpet @justinsb @ameukam

hakman · 2025-08-18T20:16:07Z

/override pull-kops-e2e-aws-upgrade-k129-ko129-to-k130-kolatest-karpenter

k8s-ci-robot · 2025-08-18T20:16:11Z

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-aws-upgrade-k129-ko129-to-k130-kolatest-karpenter

In response to this:

/override pull-kops-e2e-aws-upgrade-k129-ko129-to-k130-kolatest-karpenter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

rifelpet · 2025-08-19T01:47:26Z

FYI I started working on a model that translates an InstanceGroup to EC2NodeClass and NodePool resources:

master...rifelpet:kops:karpenter-model

I was imagining that we'd add a new karpenter controller to kops-controller that periodically fetches the instance groups (and this new userdata object) from VFS, generates the model, and reconciles the resulting resources. It should be straight forward to add models for other cloud providers too.

hakman · 2025-08-19T04:23:35Z

FYI I started working on a model that translates an InstanceGroup to EC2NodeClass and NodePool resources:

master...rifelpet:kops:karpenter-model

I was imagining that we'd add a new karpenter controller to kops-controller that periodically fetches the instance groups (and this new userdata object) from VFS, generates the model, and reconciles the resulting resources. It should be straight forward to add models for other cloud providers too.

Very nice @rifelpet, I think that is exactly the missing piece. This PR adds generates a file with the user data, which is not that easy to generate separately. This way, everything needed for generating the EC2NodeClass is in the state store.

hakman · 2025-08-22T15:28:14Z

@rifelpet @justinsb could you take a look at this one, I think it should be ready.

hakman · 2025-08-22T17:45:20Z

/test pull-kops-verify-terraform

hakman · 2025-08-23T07:06:23Z

/override pull-kops-e2e-aws-karpenter

k8s-ci-robot · 2025-08-23T07:06:26Z

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-aws-karpenter

In response to this:

/override pull-kops-e2e-aws-karpenter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hakman · 2025-08-23T08:11:13Z

/test pull-kops-scenario-aws-karpenter

hakman · 2025-08-23T08:41:18Z

/test pull-kops-scenario-aws-karpenter

hakman · 2025-08-23T09:23:00Z

/test pull-kops-scenario-aws-karpenter

ameukam · 2025-08-29T19:41:00Z

/retest

hakman · 2025-08-30T04:39:12Z

I would have expected that peter's get merged in this PR before we merge it.

@ameukam I think we decided to merge and wait for Peter's PR another 3 weeks.

rifelpet

we mention in the docs that upgrading a cluster from the old version isn't supported. This is probably worthy of a release note, especially if someone has been able to have a usable kops 1.33 cluster with karpenter 0.31.3.

rifelpet · 2025-09-05T17:19:05Z

pkg/model/components/nodeterminationhandler.go

 	nth := clusterSpec.CloudProvider.AWS.NodeTerminationHandler
+	if nth.Enabled == nil {
+		if clusterSpec.Karpenter != nil && clusterSpec.Karpenter.Enabled {
+			nth.Enabled = fi.PtrTo(false)


should we check this in api validation? to ensure spec.karpenter.enabled != spec.cloudprovider.aws.nodeTerminationHandler.enabled ?

rifelpet · 2025-09-05T17:20:49Z

upup/models/cloudup/resources/addons/karpenter.sh/k8s-1.19.yaml.template

    app.kubernetes.io/managed-by: Helm
 spec:
-  replicas: {{ ControlPlaneControllerReplicas false }}


should we preserve this?

Not sure, but added back for now.

rifelpet · 2025-09-05T17:21:08Z

upup/models/cloudup/resources/addons/karpenter.sh/k8s-1.19.yaml.template

-      {{ if not IsIPv6Only }}
-      dnsPolicy: Default
-      {{ else }}
-      # Must use ClusterFirst on IPv6 clusters in order to get DNS64
      dnsPolicy: ClusterFirst
-      {{ end }}


and preserve this?

Seems like a good idea, added back.

Signed-off-by: Ciprian Hacman <[email protected]>

hakman · 2025-09-06T05:11:28Z

we mention in the docs that upgrading a cluster from the old version isn't supported. This is probably worthy of a release note, especially if someone has been able to have a usable kops 1.33 cluster with karpenter 0.31.3.

Thanks for the review. Added the release notes piece along with the dns and replicas, so should be ready to go now.

hakman · 2025-09-06T06:16:45Z

/test pull-kops-scenario-aws-karpenter

Signed-off-by: Ciprian Hacman <[email protected]>

hakman · 2025-09-06T07:10:14Z

/test pull-kops-scenario-aws-karpenter

hakman · 2025-09-06T07:55:38Z

/override pull-kops-kubernetes-e2e-ubuntu-gce-build
/override pull-kops-e2e-aws-upgrade-k133-ko133-to-klatest-kolatest-many-addons

k8s-ci-robot · 2025-09-06T07:55:41Z

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-aws-upgrade-k133-ko133-to-klatest-kolatest-many-addons, pull-kops-kubernetes-e2e-ubuntu-gce-build

In response to this:

/override pull-kops-kubernetes-e2e-ubuntu-gce-build
/override pull-kops-e2e-aws-upgrade-k133-ko133-to-klatest-kolatest-many-addons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hakman · 2025-09-06T09:22:02Z

/test pull-kops-scenario-aws-karpenter
/override pull-kops-kubernetes-e2e-ubuntu-gce-build
/override pull-kops-e2e-aws-upgrade-k133-ko133-to-klatest-kolatest-many-addons

k8s-ci-robot · 2025-09-06T09:22:05Z

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-aws-upgrade-k133-ko133-to-klatest-kolatest-many-addons, pull-kops-kubernetes-e2e-ubuntu-gce-build

In response to this:

/test pull-kops-scenario-aws-karpenter
/override pull-kops-kubernetes-e2e-ubuntu-gce-build
/override pull-kops-e2e-aws-upgrade-k133-ko133-to-klatest-kolatest-many-addons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-09-06T14:10:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rifelpet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hakman · 2025-09-06T14:29:11Z

/unhold

k8s-ci-robot requested review from ameukam, justinsb and rifelpet August 18, 2025 19:53

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/addons area/api area/provider/aws Issues or PRs related to aws provider labels Aug 18, 2025

hakman force-pushed the karpenter-1.6.2 branch from 096f26e to 7343e7b Compare August 22, 2025 15:26

k8s-ci-robot added the area/documentation label Aug 22, 2025

hakman force-pushed the karpenter-1.6.2 branch 3 times, most recently from c8e16df to 5132f34 Compare August 22, 2025 17:13

kubernetes deleted a comment from k8s-ci-robot Aug 23, 2025

hakman force-pushed the karpenter-1.6.2 branch from 93575b2 to b84c2a4 Compare August 23, 2025 08:40

hakman force-pushed the karpenter-1.6.2 branch from b84c2a4 to 1433cd1 Compare August 23, 2025 09:16

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 23, 2025

hakman force-pushed the karpenter-1.6.2 branch from 1433cd1 to 3deb6b8 Compare August 23, 2025 09:22

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 23, 2025

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2025

k8s-ci-robot assigned ameukam Aug 29, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2025

rifelpet reviewed Sep 5, 2025

View reviewed changes

hakman added 2 commits September 6, 2025 07:44

Add release notes

1467ee0

Signed-off-by: Ciprian Hacman <[email protected]>

Add back some previous customizations

f7614ca

Signed-off-by: Ciprian Hacman <[email protected]>

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2025

hakman requested a review from rifelpet September 6, 2025 05:16

Add validation for enabling with node-termination-handler

efdc249

Signed-off-by: Ciprian Hacman <[email protected]>

hakman force-pushed the karpenter-1.6.2 branch from f1f9e85 to efdc249 Compare September 6, 2025 06:27

k8s-ci-robot added the area/nodeup label Sep 6, 2025

hakman force-pushed the karpenter-1.6.2 branch from 9d4ea86 to efdc249 Compare September 6, 2025 08:32

rifelpet approved these changes Sep 6, 2025

View reviewed changes

k8s-ci-robot assigned rifelpet Sep 6, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2025

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2025

k8s-ci-robot merged commit 06737ef into kubernetes:master Sep 6, 2025
38 checks passed

hakman deleted the karpenter-1.6.2 branch September 6, 2025 14:29

Update Karpenter to v1.6.2 #17567

Update Karpenter to v1.6.2 #17567

Conversation

hakman commented Aug 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hakman commented Aug 18, 2025

Uh oh!

k8s-ci-robot commented Aug 18, 2025

Uh oh!

rifelpet commented Aug 19, 2025

Uh oh!

hakman commented Aug 19, 2025

Uh oh!

hakman commented Aug 22, 2025

Uh oh!

hakman commented Aug 22, 2025

Uh oh!

hakman commented Aug 23, 2025

Uh oh!

k8s-ci-robot commented Aug 23, 2025

Uh oh!

hakman commented Aug 23, 2025

Uh oh!

hakman commented Aug 23, 2025

Uh oh!

hakman commented Aug 23, 2025

Uh oh!

ameukam commented Aug 29, 2025

Uh oh!

hakman commented Aug 30, 2025

Uh oh!

rifelpet left a comment

Choose a reason for hiding this comment

Uh oh!

rifelpet Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

rifelpet Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

hakman Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

rifelpet Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

hakman Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

hakman commented Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hakman commented Sep 6, 2025

Uh oh!

hakman commented Sep 6, 2025

Uh oh!

hakman commented Sep 6, 2025

Uh oh!

k8s-ci-robot commented Sep 6, 2025

Uh oh!

hakman commented Sep 6, 2025

Uh oh!

k8s-ci-robot commented Sep 6, 2025

Uh oh!

k8s-ci-robot commented Sep 6, 2025

Uh oh!

hakman commented Sep 6, 2025

Uh oh!

Uh oh!

Uh oh!

hakman commented Aug 18, 2025 •

edited

Loading

hakman commented Sep 6, 2025 •

edited

Loading