-
Notifications
You must be signed in to change notification settings - Fork 41k
DRAAdminAccess: update resourceclaim_controller metrics #132800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAAdminAccess: update resourceclaim_controller metrics #132800
Conversation
/triage accepted |
/test pull-kubernetes-unit |
/test pull-kubernetes-e2e-gce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
For other opinions and squashing into one commit.
LGTM label has been added. Git tree hash: 85ce799271e50f6166ca4cc86282bb7edab69b8a
|
/lgtm Please, squash your commits into one, thanks! |
f52486e
to
823f474
Compare
Signed-off-by: Rita Zhang <[email protected]>
823f474
to
d42a1d5
Compare
@ritazh: squashing != rebasing. Please use Still the same change, so /lgtm |
LGTM label has been added. Git tree hash: a6850d80616716453175ba8782731808eb161d16
|
Thanks for the tip. I usually rebase to make sure my changes work with the latest master in case there are changes in tests. But prow should take care of that. @enj PTAL and remove the hold |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj, pohly, ritazh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR updates https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/5018-dra-adminaccess to update resourceclaim_controller metrics.
Which issue(s) this PR is related to:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig auth
/wg device-management
/sig node
/triage-accepted
/milestone v1.34
/assign @enj @pohly