Skip to content

DRAAdminAccess: update resourceclaim_controller metrics #132800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Jul 8, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR updates https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/5018-dra-adminaccess to update resourceclaim_controller metrics.

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kube-controller-manager now reports the following metrics for ResourceClaims with admin access:
- `resourceclaim_controller_creates_total` count metric with labels admin_access (true or false), status (failure or success) to track the total number of ResourceClaims creation requests
- `resourceclaim_controller_resource_claims` gauge metric with labels admin_access (true or false), allocated (true or false) to track the current number of ResourceClaims

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/5018

/sig auth
/wg device-management
/sig node
/triage-accepted
/milestone v1.34
/assign @enj @pohly

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 8, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jul 8, 2025
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/auth Categorizes an issue or PR as relevant to SIG Auth. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. labels Jul 8, 2025
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 8, 2025
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Jul 8, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Jul 8, 2025
@k8s-ci-robot k8s-ci-robot requested review from dashpole and klueska July 8, 2025 04:38
@enj enj moved this to Needs Triage in SIG Auth Jul 8, 2025
@ritazh
Copy link
Member Author

ritazh commented Jul 8, 2025

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 8, 2025
@ritazh ritazh moved this from Needs Triage to In Review in SIG Auth Jul 8, 2025
@ritazh ritazh moved this from 🆕 New to 👀 In review in Dynamic Resource Allocation Jul 8, 2025
@ritazh
Copy link
Member Author

ritazh commented Jul 17, 2025

/test pull-kubernetes-unit
/test pull-kubernetes-e2e-gce

@ritazh
Copy link
Member Author

ritazh commented Jul 17, 2025

/test pull-kubernetes-e2e-gce

Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

For other opinions and squashing into one commit.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 85ce799271e50f6166ca4cc86282bb7edab69b8a

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2025
@bart0sh
Copy link
Contributor

bart0sh commented Jul 18, 2025

/lgtm

Please, squash your commits into one, thanks!

@ritazh ritazh force-pushed the dra-adminaccess-metrics branch from 823f474 to d42a1d5 Compare July 18, 2025 14:16
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2025
@k8s-ci-robot k8s-ci-robot requested review from bart0sh, enj and pohly July 18, 2025 14:16
@pohly
Copy link
Contributor

pohly commented Jul 18, 2025

@ritazh: squashing != rebasing.

Please use git rebase -i --keep-base in the future, then you don't loose the LGTM (at least in the k/k repo).

Still the same change, so

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a6850d80616716453175ba8782731808eb161d16

@ritazh
Copy link
Member Author

ritazh commented Jul 18, 2025

@ritazh: squashing != rebasing.

Please use git rebase -i --keep-base in the future, then you don't loose the LGTM (at least in the k/k repo).

Still the same change, so

/lgtm

Thanks for the tip. I usually rebase to make sure my changes work with the latest master in case there are changes in tests. But prow should take care of that.

@enj PTAL and remove the hold

@enj
Copy link
Member

enj commented Jul 18, 2025

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, pohly, ritazh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 768407a into kubernetes:master Jul 18, 2025
18 of 19 checks passed
@github-project-automation github-project-automation bot moved this from Tracked to Done in [sig-release] Bug Triage Jul 18, 2025
@github-project-automation github-project-automation bot moved this from Changes Requested to Closed / Done in SIG Auth Jul 18, 2025
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in SIG Node: code and documentation PRs Jul 18, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in SIG Apps Jul 18, 2025
@ritazh ritazh deleted the dra-adminaccess-metrics branch July 19, 2025 00:10
@pohly pohly moved this from 👀 In review to ✅ Done in Dynamic Resource Allocation Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Status: Done
Status: Done
Status: Closed / Done
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants