apiserver trust-controller: always include default RequestHeaders in the trust CM #133142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
/sig auth |
k8s-ci-robot
added
the
sig/auth
|
/hold My guess is merging two different headers with different case will turn into both appearing in the CM, which results in doubled groups/extras in the authenticated UserInfos. |
k8s-ci-robot
added
the
do-not-merge/hold
…the trust CM These standard headers are required for the aggregator to work correctly. Always include them in the cluster's trust config map. Signed-off-by: Stanislav Láznička <[email protected]>
Signed-off-by: Stanislav Láznička <[email protected]>
stlaz
force-pushed
the
default-remote-headers
branch
from
3d545df to
b972d64
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stlaz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
sig/testing
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds the standard Kubernetes headers for authentication with remote headers to the
kube-system/extension-apiserver-authenticationconfig map of every cluster. These headersare used to relay user information from the kube-apiserver to the aggregated API servers and
so they should always be present in the authentication discovery that's based off of this CM.
Which issue(s) this PR is related to:
Fixes #126821
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/cc enj liggitt