Skip to content

fix: Don't show VirtualBox warning when auto-selected #21088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vamshi1188
Copy link

@vamshi1188 vamshi1188 commented Jul 18, 2025

minikube should not warn users about VirtualBox driver when it was auto-selected rather than manually specified by the user.

Added DriverAutoSelected field to ClusterConfig to track whether the driver was automatically selected or manually chosen, and updated the VirtualBox warning logic to only show warnings for manually selected drivers.
Fixes #15456

Before (when VirtualBox was auto-selected)

😄  minikube v1.28.0 on Darwin 12.6.1
✨  Automatically selected the virtualbox driver. Other choices: ssh, qemu2 (experimental)
💿  Downloading VM boot image ...
👍  Starting "minikube" primary control-plane node in "minikube" cluster
🔥  Creating virtualbox VM (CPUs=2, Memory=3500MB, Disk=20000MB) ...
🐳  Preparing Kubernetes v1.25.3 on Docker 20.10.20 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...

╭──────────────────────────────────────────────────────────────────────────────╮
│                                                                              │
│ You have selected "virtualbox" driver, but there are better options!         │
│ For better performance and support consider using a different driver:        │
│     - qemu2                                                                  │
│                                                                              │
│ To turn off this warning run:                                                │
│     $ minikube config set WantVirtualBoxDriverWarning false                  │
╰──────────────────────────────────────────────────────────────────────────────╯

✅  Verifying Kubernetes components...


after:  "When VirtualBox is auto-selected"

             😄  [test-auto] minikube v1.36.0 on Ubuntu 24.04
            ✨  Automatically selected the virtualbox driver
            👍  Starting "test-auto" primary control-plane node in "test-auto" cluster
            💾  Downloading Kubernetes v1.33.2 preload ...
            🔥  Creating virtualbox VM (CPUs=2, Memory=3700MB, Disk=20000MB) ...
            🐳  Preparing Kubernetes v1.25.3 on Docker 20.10.20 ...
                ▪ Generating certificates and keys ...
                ▪ Booting up control plane ...
                ▪ Configuring RBAC rules ...
            ✅  Verifying Kubernetes components...
          


@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 18, 2025
Copy link

linux-foundation-easycla bot commented Jul 18, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 18, 2025
@k8s-ci-robot k8s-ci-robot requested review from medyagh and prezha July 18, 2025 10:04
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vamshi1188
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @vamshi1188!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 18, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @vamshi1188. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 18, 2025
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

minikube should not warn users about VirtualBox driver when it was
auto-selected rather than manually specified by the user.

Added DriverAutoSelected field to ClusterConfig to track whether the
driver was automatically selected or manually chosen, and updated the
VirtualBox warning logic to only show warnings for manually selected
drivers.

Signed-off-by: vamshi <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 18, 2025
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you plz put before/after this PR in the Description

@vamshi1188
Copy link
Author

can you plz put before/after this PR in the Description

i updated pr description with before/after

@vamshi1188 vamshi1188 requested a review from medyagh July 18, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minikube should not warn you to NOT use virtualbox if it auto-selected it
4 participants