vfkit: Extract isoPath() helper

[nirs]

For consistency with other path helpers.

[k8s-ci-robot]

Hi @nirs. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[medyagh]

/ok-to-test

[nirs]

@medyagh should be ready, I rebased on master to run the vfkit smoke test.

[minikube-pr-bot]

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21111 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 49.4s    │ 49.9s                  │
│ enable ingress │ 15.0s    │ 14.8s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 49.2s 49.7s 47.2s 49.7s 51.1s
Times for minikube (PR 21111) start: 49.7s 48.1s 47.9s 51.9s 51.7s

Times for minikube ingress: 15.0s 15.0s 15.0s 15.0s 15.0s
Times for minikube (PR 21111) ingress: 15.0s 15.0s 14.9s 14.6s 14.5s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21111 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 23.5s    │ 24.2s                  │
│ enable ingress │ 13.2s    │ 13.2s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube (PR 21111) start: 25.1s 26.1s 22.4s 22.3s 25.1s
Times for minikube start: 22.7s 22.5s 23.8s 22.2s 26.1s

Times for minikube ingress: 13.3s 13.8s 13.3s 12.8s 12.8s
Times for minikube (PR 21111) ingress: 13.3s 12.8s 13.3s 12.8s 13.8s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21111 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 24.1s    │ 21.8s                  │
│ enable ingress │ 27.6s    │ 26.5s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 26.3s 24.7s 24.9s 22.4s 22.3s
Times for minikube (PR 21111) start: 21.4s 22.2s 22.6s 21.5s 21.1s

Times for minikube ingress: 22.8s 23.8s 27.8s 39.7s 23.8s
Times for minikube (PR 21111) ingress: 22.8s 22.8s 39.8s 23.3s 23.8s

[nirs]

@medyagh The smoke test failed (error in restarting docker), but this is not related to the change. We can run the job again to be sure.

[medyagh]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, nirs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment