Skip to content

Conversation

@sAchin-680
Copy link

What type of PR is this?

/kind cleanup
/area prow

What this PR does / why we need it:

This PR introduces a new blockades rule to prevent direct modifications to the staging/ directories in the kubernetes/k8s.io repository.

These staging repos are intended to be mirrored from upstream sources (e.g., kubernetes/kubernetes), and changes should be made at the source instead. Blocking direct edits here helps maintain consistency, prevents configuration drift, and ensures changes follow the intended workflows.

Special notes for your reviewer:

  • Consistent with existing blockades patterns defined in config.yaml
  • The message clearly communicates where changes should be proposed instead

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config labels Apr 17, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @sAchin-680!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sAchin-680
Once this PR has been reviewed and has the lgtm label, please assign priyankasaggu11929 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @sAchin-680. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2025
Copy link
Author

@sAchin-680 sAchin-680 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done as per your suggestion, replaced Go module import paths with actual GitHub repo names, and ensured client-go and other existing staging repos have matching config. Let me know if anything else needs adjustment!

@BenTheElder
Copy link
Member

/ok-to-test
let's get the readme changes in, then this

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 28, 2025
@sAchin-680
Copy link
Author

Hey @BenTheElder

While running the pull-test-infra-prow-checkconfig job, I encountered the following error:

  • unknown field "missing_label_policy" in config/prow/plugins.yaml
  • Strict is set and there were warnings.

Prow job link: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/test-infra/34695/pull-test-infra-prow-checkconfig/1917219320614621184

It appears that missing_label_policy is not a recognized field in the current configuration schema, which is causing the check to fail due to --strict.

Should I go ahead and remove this field from the config, or is there an updated way to define this policy?

explanation: "k8s.gcr.io Image registry is frozen from April 2023. Please update the manifests in registry.k8s.io folder instead."

- repos:
- kubernetes/cri-api
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably fold this into the same config as above?

also fyi @chrishenzie re: kubernetes/kubernetes#130799

@sAchin-680
Copy link
Author

/test pull-test-infra-prow-checkconfig

@k8s-ci-robot
Copy link
Contributor

@sAchin-680: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-test-infra-prow-checkconfig 52d564a link true /test pull-test-infra-prow-checkconfig

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sAchin-680 sAchin-680 closed this by deleting the head repository Jul 7, 2025
- repos:
- kubernetes/kubernetes
- kubernetes/kubernetes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if possible we should avoid all the formatting changes on existing entries

- kubernetes/sample-apiserver
- kubernetes/sample-cli-plugin
- kubernetes/sample-controller
required_labels:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this config looks wrong, as do the lines below

I generated this: kubernetes/kubernetes#131351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Issues or PRs related to code in /config area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants