Skip to content

Enable the WatchListClient when testing WatchList #34699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Enable the WatchListClient when testing WatchList #34699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/jobs/kubernetes/sig-scalability/sig-scalability-experimental-periodic-jobs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ periodics:
- --env=CL2_ENABLE_WATCH_LIST_FEATURE=true
- --env=CONTAINER_IMAGE=registry-sandbox.k8s.io/pause:3.1 #TODO(ameukam): revert when registry.k8s.io is ready
Copy link
Member

@BenTheElder BenTheElder Apr 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[off-topic]

hmm @ameukam, probably we can switch this job to use the private pull-through endpoint? most of the key scale jobs use this now and should be fine even if they are NAT-ed, at least from the image pull side of things.

... will file a tracking issue

EDIT: #34701

- --env=KUBE_GCE_PRIVATE_CLUSTER=false #TODO(#29500): revert when private cluster setup is fixed
- --env=KUBE_FEATURE_GATES=WatchList=true
- --env=KUBE_FEATURE_GATES=WatchList=true,WatchListClient=true
- --extract=ci/latest
- --gcp-node-image=gci
- --gcp-master-size=n2-standard-32
Expand Down