Skip to content

upgrading to 1.33 #35056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

upgrading to 1.33 #35056

wants to merge 1 commit into from
+654 −654

Conversation

darshansreenivas
Copy link

@darshansreenivas darshansreenivas commented Jun 28, 2025 •
edited
Loading

Support of 1.33 Kubernetes release.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: darshansreenivas
Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 28, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @darshansreenivas. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 28, 2025
@k8s-ci-robot k8s-ci-robot requested review from pohly and xing-yang June 28, 2025 06:55
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 28, 2025
@xing-yang
Copy link
Contributor

Please run the script "config/jobs/kubernetes-csi/gen-jobs.sh" to generate changes in jobs.

xing-yang
xing-yang reviewed Jun 30, 2025
View reviewed changes
config/jobs/kubernetes-csi/gen-jobs.sh
@@ -27,20 +27,22 @@ k8s_versions="
1.30
1.31
1.32
1.33
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We support testing of 3 releases. Remove 1.30

xing-yang
xing-yang reviewed Jun 30, 2025
View reviewed changes
config/jobs/kubernetes-csi/gen-jobs.sh
"

# All the deployment versions we're testing.
deployment_versions="
1.30
1.31
1.32
1.33
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

xing-yang
xing-yang reviewed Jun 30, 2025
View reviewed changes
config/jobs/kubernetes-csi/gen-jobs.sh

# The latest stable Kubernetes version for testing alpha jobs
latest_stable_k8s_version="1.31"
latest_stable_k8s_version="1.32"

# Tag of the hostpath driver we should use for sidecar pull jobs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change hostpath driver to v1.17.0

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 1, 2025
@darshansreenivas
Copy link
Author

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@darshansreenivas: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xing-yang
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 1, 2025
@xing-yang
Copy link
Contributor

Can you rebase? We can get this merged after that. Thanks.

@darshansreenivas darshansreenivas force-pushed the darshan/k8s-1.33-sidecar-support branch from 3cce2c5 to 49b34d1 Compare July 5, 2025 18:23
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2025
@darshansreenivas darshansreenivas force-pushed the darshan/k8s-1.33-sidecar-support branch from d98a416 to 49b34d1 Compare July 5, 2025 18:32
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 5, 2025
@darshansreenivas darshansreenivas force-pushed the darshan/k8s-1.33-sidecar-support branch from 4d37b22 to c457eae Compare July 5, 2025 18:50
@darshansreenivas
Copy link
Author

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly Awaiting requested review from pohly

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees
No one assigned
Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darshansreenivas @k8s-ci-robot @xing-yang