Skip to content

Update statefulset.md #48240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update statefulset.md #48240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions content/en/docs/concepts/workloads/controllers/statefulset.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,8 +298,7 @@ described [above](#deployment-and-scaling-guarantees).
`Parallel` pod management tells the StatefulSet controller to launch or
terminate all Pods in parallel, and to not wait for Pods to become Running
and Ready or completely terminated prior to launching or terminating another
Pod. This option only affects the behavior for scaling operations. Updates are not
affected.
Pod. This option only affects the behavior for scaling operations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this change actually affects the meaning of the paragraph (it's removing a clarification). If we intended to change the meaning, I think we should do a different rewrite.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed expected change as described in kubernetes/kubernetes#117071 and fixed in kubernetes/kubernetes#117865. With that fix we should be explicit that this operation applies to both scaling and pod creation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be followup changes after we push forward the mechanism described in kubernetes/enhancements#961 which currently blocked on monitoring requirements to be able to progress with that effort.

Copy link
Contributor

@niranjandarshann niranjandarshann Oct 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needful as it is described in kubernetes/kubernetes#117071 and was fixed in kubernetes/kubernetes#117865 This is expected changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference in meaning between the two options (before and after) here?

-This option only affects the behavior for scaling operations. Updates are not affected.
+This option only affects the behavior for scaling operations.

To me they have the same meaning, although the original includes a clarifying statement.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim got your point. Yes we should not ignore the last sentence as well like Updates are not affected.

The sentence is mandatory.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions for improving this sentence

Suggested change
Pod. This option only affects the behavior for scaling operations.
This option only affects the behavior of scaling operations and does not impact updates.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I this this sentence will look more better .

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I have tested, this option affects updates, too. See #47085. Maybe I am not able to correctly understand what we mean by updates here.



## Update strategies
Expand Down Expand Up @@ -493,4 +492,4 @@ the `.spec.replicas` field automatically.
Read the {{< api-reference page="workload-resources/stateful-set-v1" >}}
object definition to understand the API for stateful sets.
* Read about [PodDisruptionBudget](/docs/concepts/workloads/pods/disruptions/) and how
you can use it to manage application availability during disruptions.
you can use it to manage application availability during disruptions.