-
Notifications
You must be signed in to change notification settings - Fork 15.1k
KEP-3015: PreferSameTrafficDistribution to Beta #51185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/hold cancel |
|
How is this moving to beta without a code change? I feel like either I have missed something, or we're missing a step as a project. Can we explain (PR description?) why this change is OK to make? |
|
Oh, sorry, I copied that comment from the code change PR where it was clear in context that I meant "no code changes other than updating the feature gate definition" 🙂 |
|
For beta things that are enabled by default, the docs should be the same quality that we expect for production. Ideally also for beta, off-by-default things.
“should” not must; even so, a promotion from beta to GA should normally be minor tidying and a metadata change.
We (SIG Docs) very very rarely reject graduations to beta provided the docs are at least adequate, but even so, that's the policy we've set.
|
This PR is the metadata change. It didn't seem to me that any tidying was needed; the documentation we added for Alpha explains the two new values to the same extent as we explain the existing GA value, but they're still behind the feature gate, so they shouldn't be mixed in with the GA value, but with the metadata change the docs will now indicate that they are available by default, so it didn't seem like anything else was needed. We eventually need to reorganize the whole section to reflect the deprecation of |
|
Do we need to update https://kubernetes.io/docs/concepts/services-networking/service/#traffic-distribution at all?
I think we do, because the feature gate is now enabled by default.
|
|
I guess I could change "available when the For the most part, the existing documentation fully describes the feature, and there are no changes to the feature since alpha (other than flipping the feature gate). And the deprecation of |
b752274 to
7527373
Compare
Something like that, yes, please. If we don't, people are quite likely to file issues, even if the text is factually correct. |
|
(Already made that change in the last push) |
|
Hello @danwinship 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Wednesday August 6, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you! |
thockin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
|
LGTM label has been added. Git tree hash: 3ec90c009b6de8f85c6394ee219aa1eeaa6ba0e8
|
|
/approve Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: katcosgrove, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Update feature gate data for PreferSameTrafficDistribution for 1.34
Not doing any
code/docs changes at this point; when we go to GA I'll update the docs to more clearly deprecatePreferClosein favor ofPreferSameZone.Issue
kubernetes/enhancements#3015
/hold
until KEP update merges (kubernetes/enhancements#5376)