Skip to content

Conversation

@danwinship
Copy link
Contributor

@danwinship danwinship commented Jun 5, 2025

Description

Update feature gate data for PreferSameTrafficDistribution for 1.34

Not doing any code/ docs changes at this point; when we go to GA I'll update the docs to more clearly deprecate PreferClose in favor of PreferSameZone.

Issue

kubernetes/enhancements#3015

/hold
until KEP update merges (kubernetes/enhancements#5376)

@k8s-ci-robot k8s-ci-robot added this to the 1.34 milestone Jun 5, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Jun 5, 2025
@netlify
Copy link

netlify bot commented Jun 5, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 7527373
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/684c7ad6f400b80008bc09fc

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 5, 2025
@netlify
Copy link

netlify bot commented Jun 5, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 7527373
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/684c7ad6bc90930008dd7e69
😎 Deploy Preview https://deploy-preview-51185--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@danwinship
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2025
@lmktfy
Copy link
Member

lmktfy commented Jun 11, 2025

How is this moving to beta without a code change?

I feel like either I have missed something, or we're missing a step as a project.

Can we explain (PR description?) why this change is OK to make?

@danwinship
Copy link
Contributor Author

Oh, sorry, I copied that comment from the code change PR where it was clear in context that I meant "no code changes other than updating the feature gate definition" 🙂

@lmktfy
Copy link
Member

lmktfy commented Jun 12, 2025 via email

@danwinship
Copy link
Contributor Author

minor tidying and a metadata change

This PR is the metadata change. It didn't seem to me that any tidying was needed; the documentation we added for Alpha explains the two new values to the same extent as we explain the existing GA value, but they're still behind the feature gate, so they shouldn't be mixed in with the GA value, but with the metadata change the docs will now indicate that they are available by default, so it didn't seem like anything else was needed.

We eventually need to reorganize the whole section to reflect the deprecation of PreferClose, but PreferClose doesn't actually become deprecated until PreferSameZone is GA, so that will happen in 1.35.

@lmktfy
Copy link
Member

lmktfy commented Jun 13, 2025 via email

@danwinship
Copy link
Contributor Author

I guess I could change "available when the PreferSameTrafficDistribution feature gate is enabled" to "available (unless the PreferSameTrafficDistribution feature gate is disabled)"?

For the most part, the existing documentation fully describes the feature, and there are no changes to the feature since alpha (other than flipping the feature gate). And the deprecation of PreferClose doesn't happen until PreferSameZone goes GA, so there's nothing to say about that yet either.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 13, 2025
@lmktfy
Copy link
Member

lmktfy commented Jul 2, 2025

I guess I could change "available when the PreferSameTrafficDistribution feature gate is enabled" to "available (unless the PreferSameTrafficDistribution feature gate is disabled)"?

Something like that, yes, please. If we don't, people are quite likely to file issues, even if the text is factually correct.

@danwinship
Copy link
Contributor Author

(Already made that change in the last push)

@michellengnx
Copy link
Contributor

Hello @danwinship 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Wednesday August 6, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you!

Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3ec90c009b6de8f85c6394ee219aa1eeaa6ba0e8

@katcosgrove
Copy link
Contributor

/approve

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: katcosgrove, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit 27c3ac2 into kubernetes:dev-1.34 Aug 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants