Skip to content

Conversation

HirazawaUi
Copy link
Contributor

Description

This PR adds documentation for KEP-3721.
KEP link: kubernetes/enhancements#3721

Issue

Closes: #

@k8s-ci-robot k8s-ci-robot added this to the 1.34 milestone Jun 28, 2025
Copy link

netlify bot commented Jun 28, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit f83015e
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/6892150bce58ba0008bd9f62

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 28, 2025
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 28, 2025
@lmktfy
Copy link
Contributor

lmktfy commented Jun 30, 2025

This is a work in progress

/retitle [WIP] Add documentation for the EnvFiles feature gate

@k8s-ci-robot k8s-ci-robot changed the title Add documentation for the EnvFiles Feature Gate [WIP] Add documentation for the EnvFiles feature gate Jun 30, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 27, 2025
@HirazawaUi HirazawaUi changed the title [WIP] Add documentation for the EnvFiles feature gate Add documentation for the EnvFiles feature gate Jul 27, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 27, 2025
@HirazawaUi HirazawaUi force-pushed the add-doc-3721 branch 5 times, most recently from 7ee5e19 to b47814f Compare July 28, 2025 09:41
Copy link

netlify bot commented Jul 29, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f83015e
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6892150b5608fb00082f0216
😎 Deploy Preview https://deploy-preview-51415--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 53fe740178c56d5094f482ee52c85c40790aee88

While these environment variables can store sensitive information,
please note that `emptyDir` volumes don't provide the same protection mechanisms as
dedicated Secret objects. Therefore, exposing confidential environment variables
to containers through this feature is not considered a security best practice.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this; the Secret API also has problems.

Copy link
Contributor Author

@HirazawaUi HirazawaUi Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2025
@michellengnx
Copy link
Contributor

Hello @HirazawaUi 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Wednesday August 6, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you!

Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c1017caec234d5de61203016c2f2bb635e0a2272

@michellengnx
Copy link
Contributor

/assign @tengqm

@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit f6f008a into kubernetes:dev-1.34 Aug 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants