-
Notifications
You must be signed in to change notification settings - Fork 15k
KEP-4601: promote AuthorizeWithSelectors / AuthorizeNodeWithSelectors to stable #51461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
...t/en/docs/reference/command-line-tools-reference/feature-gates/AuthorizeNodeWithSelectors.md
Outdated
Show resolved
Hide resolved
|
||
With the `AuthorizeWithSelectors` feature enabled, field and label selectors in the request | ||
are passed to the authorization webhook. The webhook can make authorization decisions | ||
The `AuthorizeWithSelectors` feature causes field and label selectors in the request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The `AuthorizeWithSelectors` feature causes field and label selectors in the request | |
When calling out to an authorization webhook, Kubernetes passes information about selectors in the request to the authorization webhook (both label selectors and field selectors). The authorization webhook can make authorization decisions |
The shortcode serves as a hint to readers that if they are running an older version, the text they read might not be accurate.
{{< feature-state feature_gate_name="AuthorizeWithSelectors" >}} | ||
|
||
With the alpha `AuthorizeWithSelectors` feature enabled, field and label selectors can be added to authorization checks. | ||
The `AuthorizeWithSelectors` feature allows adding field and label selectors to authorization checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The `AuthorizeWithSelectors` feature allows adding field and label selectors to authorization checks. | |
For CEL expressions that have an authorization context available, Kubernetes includes information about the selectors used in the request (these can be label or field selectors). |
The shortcode serves as a hint to readers that if they are running an older version, the text they read might not be accurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Tweaks recommended but not required.
/hold
because I am not sure if the code changes already merged. Do unhold this if / when they have.
* pods | ||
* secrets, configmaps, persistent volume claims and persistent volumes related | ||
to pods bound to the kubelet's node | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Restrictions based on associated Node | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit)
Can we move
In future releases, the node authorizer may add or remove permissions to ensure
kubelets have the minimal set of permissions required to operate correctly.
earlier in this page?
LGTM label has been added. Git tree hash: 073fb900bce643694bb0166b2222a4fa23bc39e2
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmktfy, reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel implementation is merged |
the netlify build wasn't successful, due to secret scanning ... |
rebased to retrigger netlify |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
that seemed to work, needs re-lgtming |
/lgtm |
LGTM label has been added. Git tree hash: df77c39e9b2677f249cada1011644f627a1109ff
|
Description
Promote KEP-4601 to stable
Issue
kubernetes/enhancements#4601
/sig auth
/cc @deads2k