Skip to content

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jul 1, 2025

Description

Promote KEP-4601 to stable

Issue

kubernetes/enhancements#4601

/sig auth
/cc @deads2k

@k8s-ci-robot k8s-ci-robot added this to the 1.34 milestone Jul 1, 2025
@k8s-ci-robot k8s-ci-robot requested a review from deads2k July 1, 2025 16:21
@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Jul 1, 2025
Copy link

netlify bot commented Jul 1, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 31f23f1
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/687945c43ae62c00085b7c72

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 1, 2025
@liggitt liggitt changed the title KEP-4601: promote to stable KEP-4601: promote AuthorizeWithSelectors / AuthorizeNodeWithSelectors to stable Jul 1, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 1, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 1, 2025

With the `AuthorizeWithSelectors` feature enabled, field and label selectors in the request
are passed to the authorization webhook. The webhook can make authorization decisions
The `AuthorizeWithSelectors` feature causes field and label selectors in the request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `AuthorizeWithSelectors` feature causes field and label selectors in the request
When calling out to an authorization webhook, Kubernetes passes information about selectors in the request to the authorization webhook (both label selectors and field selectors). The authorization webhook can make authorization decisions

The shortcode serves as a hint to readers that if they are running an older version, the text they read might not be accurate.

{{< feature-state feature_gate_name="AuthorizeWithSelectors" >}}

With the alpha `AuthorizeWithSelectors` feature enabled, field and label selectors can be added to authorization checks.
The `AuthorizeWithSelectors` feature allows adding field and label selectors to authorization checks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `AuthorizeWithSelectors` feature allows adding field and label selectors to authorization checks.
For CEL expressions that have an authorization context available, Kubernetes includes information about the selectors used in the request (these can be label or field selectors).

The shortcode serves as a hint to readers that if they are running an older version, the text they read might not be accurate.

Copy link
Contributor

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Tweaks recommended but not required.

/hold
because I am not sure if the code changes already merged. Do unhold this if / when they have.

* pods
* secrets, configmaps, persistent volume claims and persistent volumes related
to pods bound to the kubelet's node

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Restrictions based on associated Node

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit)
Can we move

In future releases, the node authorizer may add or remove permissions to ensure
kubelets have the minimal set of permissions required to operate correctly.

earlier in this page?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 073fb900bce643694bb0166b2222a4fa23bc39e2

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2025
@enj enj added this to SIG Auth Jul 7, 2025
@enj enj moved this to Needs Triage in SIG Auth Jul 7, 2025
@micahhausler micahhausler moved this from Needs Triage to In Review in SIG Auth Jul 7, 2025
@reylejano
Copy link
Member

/lgtm
/approve
feel free to unhold when code PRs have merged

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmktfy, reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member Author

liggitt commented Jul 16, 2025

/hold cancel

implementation is merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2025
@tengqm
Copy link
Contributor

tengqm commented Jul 17, 2025

the netlify build wasn't successful, due to secret scanning ...

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2025
@k8s-ci-robot k8s-ci-robot requested review from lmktfy and reylejano July 17, 2025 18:49
@liggitt
Copy link
Member Author

liggitt commented Jul 17, 2025

rebased to retrigger netlify

Copy link

netlify bot commented Jul 17, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 31f23f1
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/687945c49dd27500089a100f
😎 Deploy Preview https://deploy-preview-51461--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@liggitt
Copy link
Member Author

liggitt commented Jul 17, 2025

that seemed to work, needs re-lgtming

@lmktfy
Copy link
Contributor

lmktfy commented Jul 17, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: df77c39e9b2677f249cada1011644f627a1109ff

@k8s-ci-robot k8s-ci-robot merged commit ab5c2db into kubernetes:dev-1.34 Jul 17, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Closed / Done in SIG Auth Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants