Skip to content

KEP-5229: Add SchedulerAsyncAPICalls feature gate docs #51473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

KEP-5229: Add SchedulerAsyncAPICalls feature gate docs #51473

merged 1 commit into from
Aug 6, 2025

Conversation

macsko
Copy link
Member

@macsko macsko commented Jul 2, 2025

Description

Add SchedulerAsyncAPICalls feature gate to docs.

Issue

kubernetes/enhancements#5229

@k8s-ci-robot k8s-ci-robot added this to the 1.34 milestone Jul 2, 2025
@netlify Netlify
Copy link

netlify bot commented Jul 2, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit c47e4a8
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/68871c8020501c0008ebf280

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 2, 2025
@k8s-ci-robot k8s-ci-robot requested a review from katcosgrove July 2, 2025 08:49
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 2, 2025
@k8s-ci-robot k8s-ci-robot requested a review from reylejano July 2, 2025 08:49
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 2, 2025
@macsko macsko mentioned this pull request Jul 2, 2025
Open
4 tasks
@netlify Netlify
Copy link

netlify bot commented Jul 2, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c47e4a8
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68871c80933cfc0008276ec3
😎 Deploy Preview https://deploy-preview-51473--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lmktfy
Copy link
Contributor

lmktfy commented Jul 2, 2025

/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Jul 2, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Scheduling Jul 2, 2025
lmktfy
lmktfy reviewed Jul 3, 2025
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates/SchedulerAsyncAPICalls.md Outdated
fromVersion: "1.34"
---

Makes all API calls during scheduling asynchronous, by introducing a new kube-scheduler-wide way of handling such calls.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to read the KEP to figure out what kind of API this meant. Every Golang library has an API, for example.

Suggested change
Makes all API calls during scheduling asynchronous, by introducing a new kube-scheduler-wide way of handling such calls.
Change the kube-scheduler to make the entire scheduling cycle free of blocking requests to the Kubernetes API server.
Instead, interact with the Kubernetes API using
asynchronous code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out!

@helayoty helayoty moved this from Needs Triage to Backlog in SIG Scheduling Jul 24, 2025
@helayoty helayoty moved this from Backlog to Needs Review in SIG Scheduling Jul 24, 2025
@macsko macsko force-pushed the add_schedulerasyncapicalls_feature_gate_to_docs branch from 9ae8585 to c47e4a8 Compare July 28, 2025 06:45
@macsko
Copy link
Member Author

macsko commented Jul 28, 2025

/assign @sanposhiho
For SIG Scheduling review

sanposhiho
sanposhiho approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

sig-scheduling

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 101a9b7dfc73a5282c8d9798c350ae6388323ed3

@yujen77300
Copy link
Contributor

Hello @macsko 👋! I'm reaching out from the Docs team.

Just checking in as we approach Docs Freeze on Wednesday August 6, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you!

@macsko
Copy link
Member Author

macsko commented Aug 4, 2025

@lmktfy Can you give the approval from docs?

@macsko
Copy link
Member Author

macsko commented Aug 4, 2025

/assign @tengqm
For docs approval

@natalisucks
Copy link
Contributor

good for docs
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natalisucks, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit 57787a3 into kubernetes:dev-1.34 Aug 6, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in SIG Scheduling Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmktfy lmktfy lmktfy left review comments

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

@reylejano reylejano Awaiting requested review from reylejano

+1 more reviewer

@sanposhiho sanposhiho sanposhiho approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@tengqm tengqm

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Scheduling
Archived in project
Milestone
1.34
Development

Successfully merging this pull request may close these issues.
7 participants
@macsko @lmktfy @k8s-ci-robot @yujen77300 @natalisucks @sanposhiho @tengqm