Skip to content

Conversation

ffromani
Copy link
Contributor

@ffromani ffromani commented Jul 2, 2025

Description

Document feature gate updates for beta graduation in 1.34

Issue

kubernetes/enhancements#3695

Closes: #N/A

@k8s-ci-robot k8s-ci-robot added this to the 1.34 milestone Jul 2, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 2, 2025
Copy link

netlify bot commented Jul 2, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 428771e
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/68920117b1923200092fbee9

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 2, 2025
@k8s-ci-robot k8s-ci-robot requested a review from dipesh-rawat July 2, 2025 09:56
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 2, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 2, 2025
Copy link

netlify bot commented Jul 2, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 428771e
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/689201175109fd000780952b
😎 Deploy Preview https://deploy-preview-51476--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Early feedback; I hope it's useful.

@ffromani ffromani force-pushed the dra-podresources-beta-1.34 branch from 53b5536 to 414c432 Compare July 28, 2025 08:03
@ffromani ffromani marked this pull request as ready for review July 28, 2025 08:03
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2025
@ffromani
Copy link
Contributor Author

/cc @swatisehgal

@k8s-ci-robot k8s-ci-robot requested a review from swatisehgal July 30, 2025 16:10
@michellengnx
Copy link
Contributor

Hello @ffromani 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Wednesday August 6, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you!

@ffromani
Copy link
Contributor Author

ffromani commented Aug 4, 2025

/assign @lmktfy

@ffromani
Copy link
Contributor Author

ffromani commented Aug 4, 2025

/unassign

sorry for the noise, misread the comment. need to get technical review first

@ffromani
Copy link
Contributor Author

ffromani commented Aug 4, 2025

@guptaNswati

@guptaNswati
Copy link

LGTM, thanks for the update @ffromani

with information about the allocatable resources, enabling clients to properly
track the free compute resources on a node.
Extend the kubelet's pod resources gRPC List and Get endpoints to include resources allocated in
ResourceClaims via [Dynamic Resource Allocation](/docs/concepts/scheduling-eviction/dynamic-resource-allocation/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe link to "observability" section? Also, there is very little I can find on how DRA podresources API different from DevicePlugin. At least info on how devices are represented in podresources would be helpful

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair point, adding

@ffromani ffromani force-pushed the dra-podresources-beta-1.34 branch from 414c432 to 4bef94d Compare August 5, 2025 12:50
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 5, 2025
document feature gate changes; clarify documentation.

Signed-off-by: Francesco Romani <[email protected]>
@ffromani ffromani force-pushed the dra-podresources-beta-1.34 branch from 4bef94d to 428771e Compare August 5, 2025 13:03
Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

from node-perspective

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1b196eb1246717fc1b6ff78eaf56b5694461150a

@michellengnx
Copy link
Contributor

/assign @lmktfy for docs perspective

@guptaNswati
Copy link

guptaNswati commented Aug 5, 2025

Sharing an example of how this API is consumed by our GPU monitoring tool to show Pod resources

DCGM_FI_PROF_PCIE_RX_BYTES{gpu="0",UUID="GPU-a4f34abc-7715-3560-dcea-7238b9611a45",pci_bus_id="00000009:01:00.0",device="nvidia0",modelName="NVIDIA GH200 96GB HBM3",Hostname="sc-starwars-xxxx",container="ctr",dra_claim_name="single-gpu",dra_claim_namespace="gpu-test3",dra_device_name="gpu-0",dra_driver_name="gpu.nvidia.com",dra_pool_name="sc-starwars-xxxx",namespace="gpu-test3",pod="pod1"} 23792

DCGM_FI_PROF_PCIE_RX_BYTES{gpu="0",UUID="GPU-a4f34abc-7715-3560-dcea-7238b9611a45",pci_bus_id="00000009:01:00.0",device="nvidia0",modelName="NVIDIA GH200 96GB HBM3",Hostname="sc-starwars-xxxx",container="ctr",dra_claim_name="single-gpu",dra_claim_namespace="gpu-test3",dra_device_name="gpu-0",dra_driver_name="gpu.nvidia.com",dra_pool_name="sc-starwars-xxxx",namespace="gpu-test3",pod="pod2"} 23792

Primarily:

container="ctr",
dra_claim_name="single-gpu",
dra_claim_namespace="gpu-test3",
dra_device_name="gpu-0",dra_driver_name="gpu.nvidia.com",
dra_pool_name="sc-starwars-xxxx",
namespace="gpu-test3",
pod="pod1"

@SergeyKanzhelev
Copy link
Member

Sharing an example of how this API is consumed by our GPU monitoring tool to show Pod resources

this will be great to add to the docs

@ffromani
Copy link
Contributor Author

ffromani commented Aug 6, 2025

Sharing an example of how this API is consumed by our GPU monitoring tool to show Pod resources

this will be great to add to the docs

Sure, I can either add or perhaps @guptaNswati can add a followup with even more context. Both works for me.

@natalisucks
Copy link
Contributor

Sharing an example of how this API is consumed by our GPU monitoring tool to show Pod resources

this will be great to add to the docs

Sure, I can either add or perhaps @guptaNswati can add a followup with even more context. Both works for me.

happy for this to be in a follow-up PR – i've reviewed for the Docs Freeze and we're good to go
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natalisucks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit d76816c into kubernetes:dev-1.34 Aug 6, 2025
6 checks passed
@ffromani
Copy link
Contributor Author

ffromani commented Aug 6, 2025

Sharing an example of how this API is consumed by our GPU monitoring tool to show Pod resources

this will be great to add to the docs

Sure, I can either add or perhaps @guptaNswati can add a followup with even more context. Both works for me.

happy for this to be in a follow-up PR – i've reviewed for the Docs Freeze and we're good to go /approve

Thanks! FYI @guptaNswati - I'd be happy to help with the followup PR.

@guptaNswati
Copy link

@ffromani sure I will add this in a follow-up MR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants