Skip to content

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Jul 2, 2025

Description

This needs to reflect recent changes, new content in the KEP, and last but not least the GA graduation (if we get that far).

Issue

Fixes: kubernetes/kubernetes#131877
kubernetes/enhancements#4381

@k8s-ci-robot k8s-ci-robot added this to the 1.34 milestone Jul 2, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 2, 2025
Copy link

netlify bot commented Jul 2, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 36162b1
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/6887dc8d3e0f4d0008feb1a3

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 2, 2025
@k8s-ci-robot k8s-ci-robot requested review from klueska and tengqm July 2, 2025 16:45
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 2, 2025
Copy link

netlify bot commented Jul 2, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 36162b1
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6887dc8d2d1c120008fc8999
😎 Deploy Preview https://deploy-preview-51483--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lmktfy
Copy link
Contributor

lmktfy commented Jul 2, 2025

I suggest you mark this as a draft @pohly

@pohly pohly marked this pull request as draft July 3, 2025 06:00
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 24, 2025
@pohly pohly marked this pull request as ready for review July 24, 2025 09:35
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2025
@pohly
Copy link
Contributor Author

pohly commented Jul 24, 2025

/hold

kubernetes/kubernetes#132706 needs to be merged before the docs update.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2025
@pohly
Copy link
Contributor Author

pohly commented Jul 24, 2025

/hold cancel

This is ready for review and merging.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2025
@pohly
Copy link
Contributor Author

pohly commented Jul 24, 2025

/assign @nojnhuh

/cc @lauralorenz @shannonxtreme

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to these changes AFAICT, but the deploy preview doesn't show the "Assign Devices to Pods and Containers" section at /docs/tasks/configure-pod-container/ like kubernetes.io does. Running the website locally with these changes I still see it though.

I'm slightly more inclined to trust the local environment than the automatic preview, especially since I don't see any changes here that seem likely to have broken that, but something to look out for.


Try the following troubleshooting steps:

1. Ensure that the `kube-scheduler` component has the `DynamicResourceAllocation`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth preserving troubleshooting steps regarding the feature gate in some form to say "make sure the feature gate is not disabled"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added second bullet point for the feature gate. It does not exactly fit here because the section just checks for the presence of the API group, so I had to mention potential failure modes that could occur later on.

Alternatively this could go into the user-facing allocate-devices-dra.md, but users have no way of checking feature gates.

Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dcc376a693affc860e4db897914813036c61f72a

Copy link
Contributor

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold

You've the option to either:

  • merge as is (/unhold)
  • incorporate feedback and ask for another LGTM
    Any contributor from SIG Docs or any contributor associated with WG Device Management is welcome to add that follow-up LGTM, and anyone is welcome to unhold if @pohly makes a change that dismisses this LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not covered in this PR (and doesn't block a merge), but see how the paragraph starting at line 80 can render.

screenshot

Graphic designers may experience mental anguish on seeing this.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2025
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2025
@pohly pohly marked this pull request as draft July 28, 2025 20:20
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 28, 2025
@k8s-ci-robot k8s-ci-robot requested review from lmktfy and nojnhuh July 28, 2025 20:23
The feature gate and API examples get updated.
Enabling it is now simpler, changes are only needed
for backward compatibility.
One particular troubleshooting step fits into the
existing user-facing "allocate-devices-dra.md".

Admin-facing troubleshooting and documentation of metrics which might be of
interest can follow separately.
@pohly
Copy link
Contributor Author

pohly commented Jul 28, 2025

I applied the suggested changes, someone please LGTM again.

/hold cancel

See #51483 (review)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2025
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bbbd54b96d2ca464d02d9110f4412d5c5937ea29

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmktfy, nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nojnhuh
Copy link
Contributor

nojnhuh commented Jul 28, 2025

@pohly Can we take this PR out of draft?

@pohly pohly marked this pull request as ready for review July 30, 2025 09:04
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2025
@k8s-ci-robot k8s-ci-robot requested a review from reylejano July 30, 2025 09:04
@k8s-ci-robot k8s-ci-robot merged commit 61b4928 into kubernetes:dev-1.34 Jul 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants