-
Notifications
You must be signed in to change notification settings - Fork 15k
DRA: core update for 1.34 #51483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRA: core update for 1.34 #51483
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
I suggest you mark this as a draft @pohly |
/hold kubernetes/kubernetes#132706 needs to be merged before the docs update. |
/hold cancel This is ready for review and merging. |
/assign @nojnhuh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to these changes AFAICT, but the deploy preview doesn't show the "Assign Devices to Pods and Containers" section at /docs/tasks/configure-pod-container/ like kubernetes.io does. Running the website locally with these changes I still see it though.
I'm slightly more inclined to trust the local environment than the automatic preview, especially since I don't see any changes here that seem likely to have broken that, but something to look out for.
|
||
Try the following troubleshooting steps: | ||
|
||
1. Ensure that the `kube-scheduler` component has the `DynamicResourceAllocation` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth preserving troubleshooting steps regarding the feature gate in some form to say "make sure the feature gate is not disabled"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added second bullet point for the feature gate. It does not exactly fit here because the section just checks for the presence of the API group, so I had to mention potential failure modes that could occur later on.
Alternatively this could go into the user-facing allocate-devices-dra.md
, but users have no way of checking feature gates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: dcc376a693affc860e4db897914813036c61f72a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
You've the option to either:
- merge as is (
/unhold
) - incorporate feedback and ask for another LGTM
Any contributor from SIG Docs or any contributor associated with WG Device Management is welcome to add that follow-up LGTM, and anyone is welcome to unhold if @pohly makes a change that dismisses this LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
content/en/docs/tasks/configure-pod-container/assign-resources/set-up-dra-cluster.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/configure-pod-container/assign-resources/set-up-dra-cluster.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/configure-pod-container/assign-resources/set-up-dra-cluster.md
Outdated
Show resolved
Hide resolved
content/en/docs/tasks/configure-pod-container/assign-resources/set-up-dra-cluster.md
Outdated
Show resolved
Hide resolved
The feature gate and API examples get updated. Enabling it is now simpler, changes are only needed for backward compatibility. One particular troubleshooting step fits into the existing user-facing "allocate-devices-dra.md". Admin-facing troubleshooting and documentation of metrics which might be of interest can follow separately.
I applied the suggested changes, someone please LGTM again. /hold cancel See #51483 (review) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: bbbd54b96d2ca464d02d9110f4412d5c5937ea29
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmktfy, nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pohly Can we take this PR out of draft? |
Description
This needs to reflect recent changes, new content in the KEP, and last but not least the GA graduation (if we get that far).
Issue
Fixes: kubernetes/kubernetes#131877
kubernetes/enhancements#4381