Skip to content

WinDSR to stable updates #51505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev-1.34
Choose a base branch
from
Open

WinDSR to stable updates #51505

wants to merge 1 commit into from
+2 −2

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Jul 3, 2025

Description

Docs update for promoting kubernetes/enhancements#5100 to stable

Issue

Closes: #

/milestone v1.34
/sig windows

@k8s-ci-robot
Copy link
Contributor

@marosset: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

Description

Docs update for promoting kubernetes/enhancements#5100 to stable

Issue

Closes: #

/milestone v1.34
/sig windows

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added this to the 1.34 milestone Jul 3, 2025
@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 3, 2025
@k8s-ci-robot k8s-ci-robot requested a review from jsturtevant July 3, 2025 16:31
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 3, 2025
@k8s-ci-robot k8s-ci-robot requested a review from windsonsea July 3, 2025 16:31
@marosset marosset changed the title WinDSR to stable updates WIP - WinDSR to stable updates Jul 3, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 3, 2025
@marosset
Copy link
Contributor Author

marosset commented Jul 3, 2025

/cc @rzlink

@k8s-ci-robot
Copy link
Contributor

@marosset: GitHub didn't allow me to request PR reviews from the following users: rzlink.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @rzlink

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@marosset marosset mentioned this pull request Jul 3, 2025
Open
9 tasks
@netlify Netlify
Copy link

netlify bot commented Jul 3, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 406db73
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/6889216550f2b90008f311e9

@netlify Netlify
Copy link

netlify bot commented Jul 3, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 406db73
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6889216587f2da0008303ad4
😎 Deploy Preview https://deploy-preview-51505--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

tengqm
tengqm reviewed Jul 7, 2025
View reviewed changes
content/en/docs/concepts/services-networking/windows-networking.md Outdated
@@ -95,7 +95,7 @@ The following IPAM options are supported on Windows:

## Direct Server Return (DSR) {#dsr}

{{< feature-state for_k8s_version="v1.33" state="beta" >}}
{{< feature-state for_k8s_version="v1.34" state="stable" >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a better option could be using the feature_gate_name parameter instead of for_k8s_version and state.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated - thanks!

@marosset
WinDSR to stable updates
406db73 
Signed-off-by: Mark Rossett <[email protected]>
@marosset marosset force-pushed the win-dsr-overlay-stable-1.34 branch from d05b263 to 406db73 Compare July 29, 2025 19:30
@rzlink
Copy link

rzlink commented Jul 29, 2025

/approve

@zylxjtu
Copy link
Contributor

zylxjtu commented Jul 29, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ebdda905f3fd433d51d69c79848b6bc7629d88b2

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: msft-linliu, rzlink, zylxjtu
Once this PR has been reviewed and has the lgtm label, please assign reylejano for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marosset marosset changed the title WIP - WinDSR to stable updates WinDSR to stable updates Jul 29, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@msft-linliu msft-linliu msft-linliu approved these changes

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@windsonsea windsonsea Awaiting requested review from windsonsea

Assignees

@zylxjtu zylxjtu

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.34
Development

Successfully merging this pull request may close these issues.
6 participants
@marosset @k8s-ci-robot @rzlink @zylxjtu @tengqm @msft-linliu