Skip to content

Conversation

yliaog
Copy link
Contributor

@yliaog yliaog commented Jul 26, 2025

Description

Documentation for the DRA Extended resource feature

Issue

kubernetes/enhancements#5004

Closes: #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 26, 2025
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 26, 2025
@k8s-ci-robot k8s-ci-robot requested a review from pohly July 26, 2025 23:16
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 26, 2025
@yliaog yliaog changed the base branch from main to dev-1.34 July 26, 2025 23:22
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 26, 2025
@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pt Issues or PRs related to Portuguese language language/uk Issues or PRs related to Ukrainian language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 26, 2025
Copy link

netlify bot commented Jul 26, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit f453b00
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/689302419b76c0000867ce7e

Copy link

netlify bot commented Jul 26, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit dbbe065
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/688561d77dc0510008271bc9
😎 Deploy Preview https://deploy-preview-51710--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 26, 2025
Copy link

netlify bot commented Jul 26, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ee7b4c1
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6885638f6f8bb90008da27b4
😎 Deploy Preview https://deploy-preview-51710--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jul 26, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f453b00
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68930241d12ddd0008d06330
😎 Deploy Preview https://deploy-preview-51710--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dipesh-rawat
Copy link
Member

/remove-language ja ko pt uk zh
/remove-area localization

@k8s-ci-robot k8s-ci-robot removed language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pt Issues or PRs related to Portuguese language language/uk Issues or PRs related to Ukrainian language language/zh Issues or PRs related to Chinese language area/localization General issues or PRs related to localization labels Jul 27, 2025
defaultValue: false
fromVersion: "1.34"
---
Enables support for the [Extended Resource allocation by DRA](/docs/concepts/scheduling-eviction/dynamic-resource-allocation/#extended-resource) feature. It makes it possible to specify an extended resource name in a DeviceClass.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit)
I would link to a subsection of https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/ (which would then hyperlink to the DRA docs).

This framing is OK for alpha; at beta, we raise the quality expectation for feature docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you suggest to link to https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#extended-resources ? this section does not have DRA related information, not a good link to point to, IMO.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do, and you will need to make va small edit to that page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, added a subsection to that page, and added link to that page's subsection. PTAL

@johnbelamaric
Copy link
Member

When we document this improvement, we should also update (at least briefly):

Should we do that for alpha or just when we reach beta?

@lmktfy
Copy link
Contributor

lmktfy commented Jul 29, 2025

When we document this improvement, we should also update (at least briefly):

Should we do that for alpha or just when we reach beta?

The basic mention-and-hyperlink should be there even at alpha. For beta, if it's enabled by default, the docs should be close to GA quality.

@yliaog yliaog force-pushed the main branch 2 times, most recently from 7410045 to 650121e Compare July 29, 2025 22:53
@yliaog
Copy link
Contributor Author

yliaog commented Jul 29, 2025

added basic mention-and-hyperlink to the list of docs, PTAL

@johnbelamaric
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c0dcc4e3774245b01dc4f5db9580c8cf30d5e5c4

@michellengnx
Copy link
Contributor

Hello @yliaog 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Wednesday August 6, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you!

@yliaog
Copy link
Contributor Author

yliaog commented Aug 4, 2025

@lmktfy PTAL

Enables support for the [Extended Resource allocation by DRA](/docs/concepts/configuration/manage-resources-containers/#extended-resources-allocation-by-dra) feature.
It makes it possible to specify an extended resource name in a DeviceClass.

This feature gate has no effect unless you also enable the `DynamicResourceAllocation` feature gate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In v1.34 that gate is on by default, so we should reword. However you can disable it (and your cluster then won't pass conformance…)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm, we used the same wording in other DRA alpha features, e.g. PrioritizedList (content/en/docs/reference/command-line-tools-reference/feature-gates/DRAPrioritizedList.md), do you suggest to change this in all other DRA alpha features? any suggestion on the wording?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lmktfy please let me know your opinion on the above question, trying to resolve this before the doc freeze.

@johnbelamaric
Copy link
Member

/approve

for DRA

Co-authored-by: John Belamaric <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2025
Copy link
Contributor

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve


#### Extended resources allocation by DRA
Extended resources allocation by DRA allows cluster administrators to specify an `extendedResourceName`
in `DeviceClass`, then the devices matching the `DeviceClass` can be requested from a pod's extended
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) we prefer not to put backticks around API kinds, such as DeviceClass

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#51815 PTAL

Enables support for the [Extended Resource allocation by DRA](/docs/concepts/configuration/manage-resources-containers/#extended-resources-allocation-by-dra) feature.
It makes it possible to specify an extended resource name in a DeviceClass.

This feature gate has no effect unless the `DynamicResourceAllocation` feature gate is enabled.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should revise the DynamicResourceAllocation file so that people know to update this one when they lock DynamicResourceAllocation to enabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DynamicResourceAllocation file already has the following, what else do you like to add?

Extended resource allocation by DRA is an alpha feature and only enabled when the
DRAExtendedResource feature gate
is enabled in the kube-apiserver, kube-scheduler, and kubelet.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a06e3da6117c584439773bca425c3830d4902034

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, lmktfy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit f6c3312 into kubernetes:dev-1.34 Aug 6, 2025
6 checks passed
@k8s-ci-robot k8s-ci-robot added this to the 1.34 milestone Aug 6, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG Scheduling Aug 6, 2025
@pohly pohly moved this from 🆕 New to ✅ Done in Dynamic Resource Allocation Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants