-
Notifications
You must be signed in to change notification settings - Fork 15.1k
[KEP-5004] DRA Extended resource documentation #51710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
/remove-language ja ko pt uk zh |
defaultValue: false | ||
fromVersion: "1.34" | ||
--- | ||
Enables support for the [Extended Resource allocation by DRA](/docs/concepts/scheduling-eviction/dynamic-resource-allocation/#extended-resource) feature. It makes it possible to specify an extended resource name in a DeviceClass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit)
I would link to a subsection of https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/ (which would then hyperlink to the DRA docs).
This framing is OK for alpha; at beta, we raise the quality expectation for feature docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you suggest to link to https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#extended-resources ? this section does not have DRA related information, not a good link to point to, IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do, and you will need to make va small edit to that page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, added a subsection to that page, and added link to that page's subsection. PTAL
Should we do that for alpha or just when we reach beta? |
The basic mention-and-hyperlink should be there even at alpha. For beta, if it's enabled by default, the docs should be close to GA quality. |
7410045
to
650121e
Compare
added basic mention-and-hyperlink to the list of docs, PTAL |
/lgtm |
LGTM label has been added. Git tree hash: c0dcc4e3774245b01dc4f5db9580c8cf30d5e5c4
|
Hello @yliaog 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Wednesday August 6, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you! |
@lmktfy PTAL |
Enables support for the [Extended Resource allocation by DRA](/docs/concepts/configuration/manage-resources-containers/#extended-resources-allocation-by-dra) feature. | ||
It makes it possible to specify an extended resource name in a DeviceClass. | ||
|
||
This feature gate has no effect unless you also enable the `DynamicResourceAllocation` feature gate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In v1.34 that gate is on by default, so we should reword. However you can disable it (and your cluster then won't pass conformance…)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm, we used the same wording in other DRA alpha features, e.g. PrioritizedList (content/en/docs/reference/command-line-tools-reference/feature-gates/DRAPrioritizedList.md), do you suggest to change this in all other DRA alpha features? any suggestion on the wording?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmktfy please let me know your opinion on the above question, trying to resolve this before the doc freeze.
/approve for DRA |
content/en/docs/reference/command-line-tools-reference/feature-gates/DRAExtendedResource.md
Outdated
Show resolved
Hide resolved
Co-authored-by: John Belamaric <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
||
#### Extended resources allocation by DRA | ||
Extended resources allocation by DRA allows cluster administrators to specify an `extendedResourceName` | ||
in `DeviceClass`, then the devices matching the `DeviceClass` can be requested from a pod's extended |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) we prefer not to put backticks around API kinds, such as DeviceClass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#51815 PTAL
Enables support for the [Extended Resource allocation by DRA](/docs/concepts/configuration/manage-resources-containers/#extended-resources-allocation-by-dra) feature. | ||
It makes it possible to specify an extended resource name in a DeviceClass. | ||
|
||
This feature gate has no effect unless the `DynamicResourceAllocation` feature gate is enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should revise the DynamicResourceAllocation
file so that people know to update this one when they lock DynamicResourceAllocation
to enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DynamicResourceAllocation file already has the following, what else do you like to add?
Extended resource allocation by DRA is an alpha feature and only enabled when the
DRAExtendedResource
feature gate
is enabled in the kube-apiserver, kube-scheduler, and kubelet.
LGTM label has been added. Git tree hash: a06e3da6117c584439773bca425c3830d4902034
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnbelamaric, lmktfy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Documentation for the DRA Extended resource feature
Issue
kubernetes/enhancements#5004
Closes: #