Skip to content

Conversation

lmktfy
Copy link
Contributor

@lmktfy lmktfy commented Aug 19, 2025

Use a partial for <section> that will work with near-vanilla Docsy.

Helps with issue #41171.

Preview of the updated page.

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Aug 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign divya-mohan0209 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 19, 2025
@lmktfy
Copy link
Contributor Author

lmktfy commented Aug 19, 2025

There are two kinds of CSS change.

  1. Fixes for the video section to make it display about right after the update.
  2. Hiding the KubeWeekly sign up link (see Update site landing page #51829)

Copy link

netlify bot commented Aug 19, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 38f6e4c
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68c5813e726fa90008fbdcff
😎 Deploy Preview https://deploy-preview-51969--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lmktfy
Copy link
Contributor Author

lmktfy commented Aug 21, 2025

Oh, hmm. It worked on my machine when I previewed it.

/retitle [WIP] Use Docsy-friendly section partial

@k8s-ci-robot k8s-ci-robot changed the title Use Docsy-friendly section partial [WIP] Use Docsy-friendly section partial Aug 21, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 2, 2025
@lmktfy lmktfy force-pushed the 20250819_tweak_section_partial branch from 4a8cd65 to ae7fa1b Compare September 7, 2025 14:39
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 7, 2025
@lmktfy
Copy link
Contributor Author

lmktfy commented Sep 7, 2025

/retitle Use Docsy-friendly section partial

@dipesh-rawat @natalisucks this is ready for a review (I hope - it works on my machine)

@k8s-ci-robot k8s-ci-robot changed the title [WIP] Use Docsy-friendly section partial Use Docsy-friendly section partial Sep 7, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2025
@lmktfy lmktfy force-pushed the 20250819_tweak_section_partial branch from ae7fa1b to 6260948 Compare September 7, 2025 20:54
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 7, 2025
Use a partial for <section> that will work with near-vanilla Docsy.
@lmktfy lmktfy force-pushed the 20250819_tweak_section_partial branch from 6260948 to 38f6e4c Compare September 13, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants