-
Notifications
You must be signed in to change notification settings - Fork 15.1k
[en] Fixes typo in documentation #52519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[en] Fixes typo in documentation #52519
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Any other fixes you can find in this file while you're at it? I don't think the existing text is a typo, although not a commonly spoken style. So I do think this update makes sense, but on its own it's pretty trivial. |
@stmcginnis I found another typo in https://kubernetes.io/docs/concepts/cluster-administration/swap-memory-management/ instead of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 50d8482565ac47cb76a638dc4f0d51cb4d71ebdf
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DhritiShikhar, you can try to improve much more rather than a trival change, which is not very suggested.
Kubernetes clusters only consider the IP families present on the Pods, Services and Nodes objects, | ||
independently of the existing IPs of the represented objects. Per example, a server or a pod can have multiple | ||
independently of the existing IPs of the represented objects. For example, a server or a pod can have multiple | ||
IP addresses on its interfaces, but only the IP addresses in `node.status.addresses` or `pod.status.ips` are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IP addresses on its interfaces, but only the IP addresses in `node.status.addresses` or `pod.status.ips` are | |
IP addresses assigned to its interfaces, but only the IP addresses in `node.status.addresses` or `pod.status.ips` are |
independently of the existing IPs of the represented objects. Per example, a server or a pod can have multiple | ||
independently of the existing IPs of the represented objects. For example, a server or a pod can have multiple | ||
IP addresses on its interfaces, but only the IP addresses in `node.status.addresses` or `pod.status.ips` are | ||
considered for implementing the Kubernetes network model and defining the type of the cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
considered for implementing the Kubernetes network model and defining the type of the cluster. | |
considered when implementing the Kubernetes network model and defining the cluster type. |
No description provided.