Skip to content

Conversation

Davo911
Copy link
Contributor

@Davo911 Davo911 commented Feb 24, 2025

What this PR does / why we need it:
Now as Ginkgo label filters are enabled the cleartext bracket labels marking destructive tests should move too.

Release note:

NONE

Signed-off-by: Thomas-David Griedel [email protected]

Removed the cleartext bracket label and used Ginkgo labels for destructive tests
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 24, 2025
@kubevirt-bot
Copy link
Contributor

Hi @Davo911. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@akalenyu
Copy link
Collaborator

/test all

Davo911 added 3 commits March 3, 2025 15:07
For this to also work in the test jobs, the proper variable needs to be utilized

Signed-off-by: Thomas-David Griedel [email protected]
@Davo911
Copy link
Contributor Author

Davo911 commented Mar 5, 2025

Forgot to commit the changes in the test scripts to pick up the labels
@akalenyu

@Davo911
Copy link
Contributor Author

Davo911 commented Mar 13, 2025

Could we kick off the /test all again here @akalenyu

@akalenyu
Copy link
Collaborator

sure!
/test all

Copy link
Collaborator

@akalenyu akalenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed checking this out.
So I think we have outsiders relying on skipping the destructive test set using ginkgo.skip. Maybe we could go with duplicates for a while until those are fixed?

@Davo911
Copy link
Contributor Author

Davo911 commented Mar 13, 2025

You are right, for compatibility, we should keep them both.
As they don't work together at the same time a check is neccesary though.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2025
@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 2, 2025
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign akalenyu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Sep 5, 2025

Coverage Status

coverage: 59.133% (+0.02%) from 59.115%
when pulling d3cc203 on Davo911:move-destructive-flag-to-label-filter
into 54bac42 on kubevirt:main.

Signed-off-by: Thomas-David Griedel [email protected]
@Davo911
Copy link
Contributor Author

Davo911 commented Sep 5, 2025

/test all

@Davo911
Copy link
Contributor Author

Davo911 commented Sep 5, 2025

/remove-lifecycle stale

@kubevirt-bot kubevirt-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 5, 2025
Signed-off-by: Thomas-David Griedel [email protected]
@kubevirt-bot kubevirt-bot added size/M dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 7, 2025
@Davo911 Davo911 force-pushed the move-destructive-flag-to-label-filter branch from aa1078f to 1776c96 Compare September 7, 2025 22:47
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. size/M labels Sep 7, 2025
@Davo911 Davo911 force-pushed the move-destructive-flag-to-label-filter branch from 1776c96 to d47f80f Compare September 7, 2025 22:55
@kubevirt-bot kubevirt-bot added size/M and removed size/L labels Sep 7, 2025
Signed-off-by: Thomas-David Griedel [email protected]
@Davo911
Copy link
Contributor Author

Davo911 commented Sep 8, 2025

/test pull-containerized-data-importer-e2e-ceph-wffc

2 similar comments
@Davo911
Copy link
Contributor Author

Davo911 commented Sep 9, 2025

/test pull-containerized-data-importer-e2e-ceph-wffc

@Davo911
Copy link
Contributor Author

Davo911 commented Sep 16, 2025

/test pull-containerized-data-importer-e2e-ceph-wffc

@kubevirt-bot
Copy link
Contributor

@Davo911: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-containerized-data-importer-e2e-ceph-wffc d3cc203 link true /test pull-containerized-data-importer-e2e-ceph-wffc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 3, 2025
@kubevirt-bot kubevirt-bot requested a review from akalenyu October 3, 2025 11:51
@Davo911 Davo911 force-pushed the move-destructive-flag-to-label-filter branch from 34187a7 to d3cc203 Compare October 3, 2025 11:53
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Oct 3, 2025
@Davo911 Davo911 marked this pull request as draft October 3, 2025 11:54
@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants