-
Notifications
You must be signed in to change notification settings - Fork 291
Move cleartext destructive labels to ginkgo label filters #3642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Move cleartext destructive labels to ginkgo label filters #3642
Conversation
Signed-off-by: Thomas-David Griedel [email protected] Removed the cleartext bracket label and used Ginkgo labels for destructive tests
Hi @Davo911. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test all |
Signed-off-by: Thomas-David Griedel <[email protected]>
For this to also work in the test jobs, the proper variable needs to be utilized Signed-off-by: Thomas-David Griedel [email protected]
Forgot to commit the changes in the test scripts to pick up the labels |
Could we kick off the /test all again here @akalenyu |
sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed checking this out.
So I think we have outsiders relying on skipping the destructive test set using ginkgo.skip. Maybe we could go with duplicates for a while until those are fixed?
You are right, for compatibility, we should keep them both. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
Signed-off-by: Thomas-David Griedel <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Thomas-David Griedel [email protected]
Signed-off-by: Thomas-David Griedel [email protected]
/test all |
/remove-lifecycle stale |
Signed-off-by: Thomas-David Griedel [email protected]
aa1078f
to
1776c96
Compare
Signed-off-by: Thomas-David Griedel [email protected]
1776c96
to
d47f80f
Compare
Signed-off-by: Thomas-David Griedel [email protected]
/test pull-containerized-data-importer-e2e-ceph-wffc |
2 similar comments
/test pull-containerized-data-importer-e2e-ceph-wffc |
/test pull-containerized-data-importer-e2e-ceph-wffc |
@Davo911: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
34187a7
to
d3cc203
Compare
What this PR does / why we need it:
Now as Ginkgo label filters are enabled the cleartext bracket labels marking destructive tests should move too.
Release note: