Allow mutating only PVC requested size to the minimum supported #3890
Conversation
by the relevant StorageProfile, but without applying the StorageProfile accessModes, volumeMode, or filesystemOverhead. Signed-off-by: Arnon Gilboa <[email protected]>
kubevirt-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
kubevirt-bot
added
the
do-not-merge/hold
|
@arnongilboa: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| // PvcApplyStorageProfileLabel tells whether the PVC should be rendered by the mutating webhook based on StorageProfiles | ||
| PvcApplyStorageProfileLabel = CDIComponentLabel + "/applyStorageProfile" | ||
| // PvcApplyStorageProfileMinimumSize tells whether the PVC mutating webhook rendering should apply only the StorageProfile minimum volume size if exists | ||
| PvcApplyStorageProfileMinimumSize = "minimumSize" |
There was a problem hiding this comment.
Do we plan to add more applyStorageProfile modes? (accesmode, volume mode, etc)
There was a problem hiding this comment.
Even if it's just this one we should update the repository's docs with info about the possible options.
There was a problem hiding this comment.
This PR is just an option for consideration. I'm not sure it's the best one, and that's why it's on hold :)
4 participants
What this PR does / why we need it:
Allow mutating only the PVC requested size to the minimum supported by the relevant
StorageProfile, but without applying theStorageProfileaccessModes,volumeMode, orfilesystemOverhead.Release note: