add diff_pixels, diff_ratio for acceptence, similar as playwright node.js version #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hot .png files inside
|
This looks great, what do you think @kumaraditya303 |
| author_email="", | ||
| description="A pytest wrapper for snapshot testing with playwright", | ||
| name="pytest-playwright-visual", | ||
| author="Symon Storozhenko", |
There was a problem hiding this comment.
You shouldn't be changing the author nor the project name.
There was a problem hiding this comment.
@hgye are you open to changing this so we can get this merged in?
|
Decided to fork and implement these changes and a bunch more: https://github.com/iloveitaly/pytest-playwright-visual-snapshot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.