Improve handling of model parameters #98
                
     Open
            
            
          
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Hi Avanti,
I modified how DeepLIFT handles model parameters. The current behaviour is to store them as
numpy arrays. I converted them to tensorflow variables. This change resulted in a 10x
speed up for a VGG-16.
This code snippet gives the following numbers on (AMD Ryzen 1950X 16 Cores, 64 GB RAM, RTX 2080 TI) for a VGG-16:
With tensorflow variables:
With numpy variables:
Also the speedup is decent, the current code would break backwards compabibilty.
If any code relies on
Conv2d.kernelto be a numpy array. If you would consider this a problem, one could create extra variables likeConv2d._tf_kernelwith the tensorflow variable.Cheers,
Leon