-
Notifications
You must be signed in to change notification settings - Fork 454
[WIP]chore: restructure documentation directory #1133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Move documentation files from doc/ to docs/source/ directory - Reorganize English and Chinese documentation files Signed-off-by: staryxchen <[email protected]>
Summary of ChangesHello @staryxchen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant refactoring of the project's documentation directory structure. The primary goal is to centralize and standardize the location of all source documentation files, improving overall organization and maintainability. This change lays the groundwork for a clearer and more scalable documentation system. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request restructures the documentation by moving files from doc/ to docs/source/. While the changes are primarily file moves, I've taken the opportunity to review the content of the moved documentation files. My review includes feedback on broken image links, typos, grammatical errors, and inconsistencies that I found. Addressing these issues will improve the quality and clarity of the documentation.
|
After merging doc and docs, we should verify the website links remain valid across all projects. CC. @ShangmingCai @ykwd |
|
I'm not sure if it's because this is still a work in progress, but in the current PR it looks like the doc files were simply moved into the In fact, most of the content in |
|
Another question. Will we continue to maintain |
Yes, I just merge doc/ into docs/ without changing any content now, I will keep on working on it. |
I think we just retain a few necessary documents in chinese is enough. |
Agree with that. |
LGTM |
|
In fact, we only need to keep a small portion of the documents in the doc folder; the rest of the content is duplicated with that in the docs folder and should be deleted. In addition, since we are only keeping the content in the docs folder, should we no longer retain the Chinese content? @staryxchen @stmatengss @ykwd |
As discussed above, we can retain the existing |
Generally, we don't recommend users obtain information directly from .md files, but rather through the documents website, as its directory structure is clearer and it provides search functionality. Furthermore, the vllm and sgalng do not retain Chinese documentation, perhaps because Google Chrome already offers convenient webpage translation features : > Based on the initial discussion[#1060 ], the ideal document should look like this :[#1153 ] please help review it~ |
Description
Type of Change
How Has This Been Tested?
N/A
Checklist