code format & enable code format checking in ci #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doujiang24
force-pushed
the
format-check
branch
7 times, most recently
from
ec50b9d to
b9ec8b3
Compare
doujiang24
force-pushed
the
format-check
branch
6 times, most recently
from
36a367a to
a46935d
Compare
|
Good Work! @xiaguan PTAL. Could you also add code quality check and git blame ignore to this PR? |
|
Many thanks for your contribution. This PR appears to overlap with #638. Would you be willing to pivot to reviewing that PR instead? Once we converge on the formatting side—clang-format usage, specifics, etc.—I’m happy to add you as co-author so we can shepherd the formatting patch all the way in. |
xiaguan
approved these changes
Jul 31, 2025
Signed-off-by: doujiang24 <[email protected]>
doujiang24
force-pushed
the
format-check
branch
from
a46935d to
e5b3ee2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force follow the .clang-format, to reduce code style changes in PRs, make PRs review easier.