[Store] Add master side QP calculation #742
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmatengss
force-pushed
the
add_master_side_cal
branch
from
db19705 to
5d6c4a2
Compare
|
@SgtPepperr could you review this PR? |
SgtPepperr
reviewed
Aug 19, 2025
| return tl::make_unexpected(ErrorCode::INTERNAL_ERROR); | ||
| } | ||
| return PingResponse(view_version_, client_status); | ||
| return PingResponse(view_version_, client_status, 0); |
There was a problem hiding this comment.
it looks like qp_count should be passed in as a parameter here？
| MasterMetricManager::instance().inc_ping_requests(); | ||
|
|
||
| auto result = master_service_.Ping(client_id); | ||
| auto result = master_service_.Ping(client_id, 0); |
There was a problem hiding this comment.
it looks like qp_count should be passed in as a parameter here？
| // Increment cluster total QP number based on client's reported QP count | ||
| MasterMetricManager::instance().inc_cluster_total_qp_num( | ||
| result.value().total_qp_num); | ||
| } |
There was a problem hiding this comment.
The current implementation increments QP count on every ping operation which may cause inaccurate counting, so maybe we should maintain a map<uuid, qpcount> in master_metrics to update each client's status during pings and sum all qpcounts when queried.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #738