Add API for closing handles #761
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alogfans
reviewed
Aug 20, 2025
| .def("batch_unregister_memory", | ||
| &TransferEnginePy::batchUnregisterMemory) | ||
| .def("get_local_topology", &TransferEnginePy::getLocalTopology) | ||
| .def("free_remote_segment", &TransferEnginePy::freeRemoteSegment) |
There was a problem hiding this comment.
Renaming it as "close_remote_segment" may be better.
| LOG(ERROR) << "NvlinkTransport: cudaIpcCloseMemHandle failed: " | ||
| << cudaGetErrorString(err); | ||
| } | ||
| } |
There was a problem hiding this comment.
Add one line to remove this entry in remap_entries_ after cudaIpcCloseMemHandle.
|
Please fix the CI issues before further reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while using IPC NVLink transport with SGLang, sender will continue holding an opened IPC handle to receiver even if receiver dies and deallocates its memory. Adds ability for sender to close the ipc handle with
cudaIpcCloseMemHandle, which is triggered byengine.free_remote_segment.cc @ShangmingCai @ByronHsu