Skip to content

Fix TCP Transport Handshake Daemon Initialization #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix TCP Transport Handshake Daemon Initialization #846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mooncake-transfer-engine/include/transport/tcp_transport/tcp_transport.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ class TcpTransport : public Transport {
std::shared_ptr<TransferMetadata> meta,
std::shared_ptr<Topology> topo);

int startHandshakeDaemon();

int allocateLocalSegmentID(int tcp_data_port);

int registerLocalMemory(void *addr, size_t length,
Expand Down
12 changes: 12 additions & 0 deletions mooncake-transfer-engine/src/transport/tcp_transport/tcp_transport.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,12 @@ TcpTransport::~TcpTransport() {
metadata_->removeSegmentDesc(local_server_name_);
}

int TcpTransport::startHandshakeDaemon() {
return metadata_->startHandshakeDaemon(nullptr,
metadata_->localRpcMeta().rpc_port,
metadata_->localRpcMeta().sockfd);
}

int TcpTransport::install(std::string &local_server_name,
std::shared_ptr<TransferMetadata> meta,
std::shared_ptr<Topology> topo) {
Expand All @@ -292,6 +298,12 @@ int TcpTransport::install(std::string &local_server_name,
return -1;
}

ret = startHandshakeDaemon();
if (ret) {
LOG(ERROR) << "TcpTransport: cannot start handshake daemon";
return -1;
}

ret = metadata_->updateLocalSegmentDesc();
if (ret) {
LOG(ERROR) << "TcpTransport: cannot publish segments, "
Expand Down
Loading