-
Notifications
You must be signed in to change notification settings - Fork 389
[Store] Add Pure C Interface of Client #866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for your contributions! 1. Can you wrap more APIs (e.g., batch set/get) into C files? 2. It's recommended to add C-based end-to-end tests for CI testing. |
Thank you, I will try |
1374ca3
to
ba2971a
Compare
This PR builds on the previous submission by:
|
extern "C" { | ||
#endif // __cplusplus | ||
|
||
// types.h 中的 ErrorCode Code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// types.h 中的 ErrorCode Code | |
// ErrorCode Code in types.h |
|
||
using namespace mooncake; | ||
|
||
// 管理 client 对象的生命周期 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// 管理 client 对象的生命周期 | |
// Managing the lifecycle of client objects |
Thank you. |
@JINGE-ui could you update this PR? |
Two test cases cannot pass in CI. |
This PR provides a C interface wrapper for mooncake-store. See client_c.h and client_c.cpp for details. After compiling Mooncake Store, you can use the static library file libmooncake_store.a and the C header file client_c.h for further development.
At present, client_c.h only wraps Client's key functions, such as Create, RegisterLocalMemory, MountSegment, Get, Put, IsExist, and Remove.