Skip to content

Conversation

FrancoGiachetta
Copy link
Contributor

@FrancoGiachetta FrancoGiachetta commented Aug 21, 2025

Use types-rs's QM31 implementation

Description

This PR replaces all QM31 operations implemented in Cairo VM for the one in starknet-types-core, implemented in this PR.

In addition to this, starknet-crypto was updated to 0.8.0. This was done due to incompatibilities with starknet-types-core. starknet-crypto was using 0.7.3 an older version of starknet-types-core than the version this PR needs which is 0.2.0.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

Copy link

github-actions bot commented Aug 21, 2025

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     24.319 s ±  0.081 s    [User: 23.457 s, System: 0.860 s]
  Range (min … max):   24.262 s … 24.376 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     24.282 s ±  0.022 s    [User: 23.440 s, System: 0.840 s]
  Range (min … max):   24.266 s … 24.298 s    2 runs
 
Summary
  hyper_threading_pr threads: 1 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     13.199 s ±  0.008 s    [User: 23.527 s, System: 0.856 s]
  Range (min … max):   13.193 s … 13.204 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     13.291 s ±  0.110 s    [User: 23.582 s, System: 0.885 s]
  Range (min … max):   13.213 s … 13.369 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.01 ± 0.01 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.083 s ±  0.493 s    [User: 35.664 s, System: 1.043 s]
  Range (min … max):    9.734 s … 10.432 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.220 s ±  0.005 s    [User: 35.836 s, System: 1.037 s]
  Range (min … max):   10.217 s … 10.224 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.01 ± 0.05 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):      9.696 s ±  0.009 s    [User: 36.363 s, System: 1.029 s]
  Range (min … max):    9.690 s …  9.702 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):      9.879 s ±  0.023 s    [User: 36.088 s, System: 1.046 s]
  Range (min … max):    9.863 s …  9.895 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.02 ± 0.00 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):      9.742 s ±  0.127 s    [User: 36.497 s, System: 1.067 s]
  Range (min … max):    9.652 s …  9.832 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):      9.903 s ±  0.107 s    [User: 36.469 s, System: 1.086 s]
  Range (min … max):    9.828 s …  9.979 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.02 ± 0.02 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.045 s ±  0.056 s    [User: 36.508 s, System: 1.137 s]
  Range (min … max):   10.006 s … 10.085 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):      9.902 s ±  0.155 s    [User: 36.645 s, System: 1.127 s]
  Range (min … max):    9.792 s … 10.011 s    2 runs
 
Summary
  hyper_threading_pr threads: 16 ran
    1.01 ± 0.02 times faster than hyper_threading_main threads: 16


Copy link

github-actions bot commented Aug 21, 2025

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.042 ± 0.015 2.025 2.064 1.00
head big_factorial 2.057 ± 0.005 2.048 2.063 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 1.976 ± 0.012 1.960 1.993 1.00
head big_fibonacci 1.994 ± 0.007 1.984 2.008 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.013 ± 0.068 6.947 7.195 1.00
head blake2s_integration_benchmark 7.226 ± 0.192 7.124 7.763 1.03 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.106 ± 0.011 2.091 2.129 1.00
head compare_arrays_200000 2.135 ± 0.021 2.122 2.194 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.412 ± 0.028 1.392 1.476 1.01 ± 0.02
head dict_integration_benchmark 1.401 ± 0.010 1.384 1.413 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.174 ± 0.007 1.169 1.193 1.00
head field_arithmetic_get_square_benchmark 1.195 ± 0.010 1.187 1.220 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.127 ± 0.039 7.073 7.205 1.00
head integration_builtins 7.296 ± 0.104 7.207 7.582 1.02 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.186 ± 0.096 7.126 7.456 1.00
head keccak_integration_benchmark 7.297 ± 0.042 7.256 7.399 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.067 ± 0.013 2.046 2.084 1.00
head linear_search 2.080 ± 0.014 2.063 2.112 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.478 ± 0.022 1.457 1.520 1.01 ± 0.02
head math_cmp_and_pow_integration_benchmark 1.470 ± 0.008 1.458 1.480 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.412 ± 0.009 1.402 1.433 1.00
head math_integration_benchmark 1.420 ± 0.008 1.409 1.432 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.183 ± 0.016 1.169 1.225 1.00 ± 0.01
head memory_integration_benchmark 1.180 ± 0.007 1.174 1.198 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.487 ± 0.010 1.477 1.506 1.00
head operations_with_data_structures_benchmarks 1.497 ± 0.004 1.492 1.504 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 518.4 ± 6.3 514.7 535.2 1.00
head pedersen 520.9 ± 5.8 517.7 536.9 1.00 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 593.4 ± 3.2 589.6 599.5 1.00
head poseidon_integration_benchmark 600.2 ± 4.0 593.2 604.8 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.736 ± 0.006 1.729 1.748 1.00
head secp_integration_benchmark 1.755 ± 0.015 1.744 1.794 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 615.6 ± 3.9 612.8 626.2 1.04 ± 0.01
head set_integration_benchmark 593.8 ± 3.8 589.7 603.3 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.018 ± 0.027 3.989 4.091 1.00
head uint256_integration_benchmark 4.087 ± 0.014 4.064 4.103 1.02 ± 0.01

Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.66%. Comparing base (c42f95a) to head (2e2ffb1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2179      +/-   ##
==========================================
- Coverage   96.68%   96.66%   -0.02%     
==========================================
  Files         104      104              
  Lines       44014    43749     -265     
==========================================
- Hits        42553    42292     -261     
+ Misses       1461     1457       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant