-
Notifications
You must be signed in to change notification settings - Fork 203
Add support for Hint Data caching #2220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JulianGCalderon
wants to merge
2
commits into
opt-vm
Choose a base branch
from
add-hint-caching
base: opt-vm
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark Results for unmodified programs 🚀
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## opt-vm #2220 +/- ##
==========================================
- Coverage 96.66% 96.65% -0.02%
==========================================
Files 103 103
Lines 43682 43694 +12
==========================================
+ Hits 42227 42234 +7
- Misses 1455 1460 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Hint Data caching
This PR adds support for caching the compiled hint data between executions of the same contract.
I benchmarked some transactions and found a performance improvement of 20% when running old transactions (Cairo 0).
Some limitations:
This PR is not breaking, but to achieve this I had to expose an unsafe API. See safety notes on the
set_hint_datafunction.This only works without the
extensive_hintsfeature, which is a problem due to the way Cargo unifies features.Checklist