perf(tracer): precompute prime/constants in get_data and avoid clones #2256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hi, @radik878! Do you have any benchmark that shows any improvement? If so, please share the results |
Contributor
Author
|
Before: and after: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precompute prime_bigint, half_prime, 2^40, and 2^100 once per request in get_data() to avoid per-element parsing and exponentiation.
Refactor field_element_repr() to accept precomputed constants by reference, removing unnecessary clone()s and repeated BigInt computations.
Rationale: Reduce CPU and allocations when mapping memory values to strings for the tracer API, leveraging existing cached CAIRO_PRIME.