Skip to content

chore(l1): remove old snap sync dead code #5283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 12, 2025
Merged

chore(l1): remove old snap sync dead code #5283

merged 4 commits into from
Nov 12, 2025
+5 −17

Conversation

@Oppen
Copy link
Contributor

@Oppen Oppen commented Nov 11, 2025

Motivation

I found some dead code looking for uses of lazy_static.

Description

Remove no longer used variables.

@Oppen Oppen requested a review from a team as a code owner November 11, 2025 20:59
Copilot AI review requested due to automatic review settings November 11, 2025 20:59
@github-actions github-actions bot added the L1 Ethereum client label Nov 11, 2025
Copilot finished reviewing on behalf of Oppen November 11, 2025 21:01
Copilot AI reviewed Nov 11, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unused lazy_static variables related to old snap sync functionality, specifically eliminating dead code that computed state trie segment boundaries.

  • Removes three unused lazy_static variables: STATE_TRIE_SEGMENT_SIZE, STATE_TRIE_SEGMENTS_START, and STATE_TRIE_SEGMENTS_END

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 11, 2025 •
edited
Loading

Lines of code report

Total lines added: 0
Total lines removed: 8
Total lines changed: 8

Detailed view 
+--------------------------------------+-------+------+
| File                                 | Lines | Diff |
+--------------------------------------+-------+------+
| ethrex/crates/networking/p2p/sync.rs | 1360  | -8   |
+--------------------------------------+-------+------+

@github-project-automation github-project-automation bot moved this to In Review in ethrex_l1 Nov 11, 2025
@jrchatruc jrchatruc enabled auto-merge November 12, 2025 12:59
@jrchatruc jrchatruc added this pull request to the merge queue Nov 12, 2025
Merged via the queue into main with commit a39000d Nov 12, 2025
38 checks passed
@jrchatruc jrchatruc deleted the chore/dead_code branch November 12, 2025 14:05
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@MegaRedHand MegaRedHand MegaRedHand approved these changes

@jrchatruc jrchatruc jrchatruc approved these changes

Assignees

@Oppen Oppen

Labels

L1 Ethereum client

Projects

ethrex_l1
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Oppen @MegaRedHand @jrchatruc