Skip to content

Conversation

hustxiayang
Copy link

PR Description

In json model, it should also support the conversion for gemini models.

Relevant issues

#895

@hustxiayang hustxiayang marked this pull request as draft May 24, 2025 19:14
@hustxiayang hustxiayang marked this pull request as ready for review May 24, 2025 20:44
@lkuligin
Copy link
Collaborator

@hustxiayang could you fix linting issues and resolve conflicts, please?

@hustxiayang
Copy link
Author

@lkuligin I have fixed these issues. Could you please review it? Sorry for the delay!

Copy link
Collaborator

@mdrxy mdrxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should rewrite to use a sentinel value, possibly - especially with v3 on the horizon. Let me know your thoughts @lkuligin

@mdrxy mdrxy added the vertex label Sep 17, 2025
@lkuligin lkuligin closed this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants