Skip to content

Fix firstIncompleteStep when all step are done #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix firstIncompleteStep when all step are done #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fd519c
Fix firstIncompleteStep when all step are done
hguenot Sep 3, 2022
d7e05d0
Fix phpstan false positive typehinting error
hguenot Sep 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ parameters:
path: src/AbstractWizard.php

-
message: "#^Method Arcanist\\\\AbstractWizard\\:\\:firstIncompleteStep\\(\\) should return Arcanist\\\\WizardStep but returns Arcanist\\\\WizardStep\\|null\\.$#"
message: "#^Method Arcanist\\\\AbstractWizard\\:\\:firstIncompleteStep\\(\\) should return Arcanist\\\\WizardStep but returns mixed\\.$#"
count: 1
path: src/AbstractWizard.php

Expand Down
2 changes: 1 addition & 1 deletion src/AbstractWizard.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ private function isLastStep(): bool

private function firstIncompleteStep(): WizardStep
{
return collect($this->availableSteps())->first(fn (WizardStep $step) => !$step->isComplete());
return collect($this->availableSteps())->first(fn (WizardStep $step) => !$step->isComplete(), $this->steps[count($this->steps) - 1]);
}

/**
Expand Down