Add eventStream signature to ResponseFactory contract #56306
Merged
+10
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit description
Adds
eventStream
toIlluminate\Contracts\Routing\ResponseFactory
in order to add type support for this method, aligning this with the same behavior that we have forstream
of whicheventStream
is a convenient wrapper.Why this change
At this time the
ResponseFactory
contract does not include a signature for theeventStream
method. However, the function does exist on the underlying concrete implementation returned by theresponse()
helper.Not having this included can cause some false positive warnings and errors when statically analyzing a codebase using the
eventStream
function, such as when using intellisense in VS Code. Additionally, this can throw off AI agents from using the method, even if directly instructed to (tested using Claude Sonnet 4).The method is already described on the
Response
facade–this PR would align the response helper with the facade.This is a additive feature and does not introduce breaking changes.
Of note:
I do not see any existing tests for
eventStream
, but here is additionally PRs for context on the function.