Skip to content

[12.x] Use ReplacesAttributes::replaceWhileKeepingCase() also for imploded parameters #57576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 13 commits into
base: 12.x
Choose a base branch
from
Draft

[12.x] Use ReplacesAttributes::replaceWhileKeepingCase() also for imploded parameters #57576

wants to merge 13 commits into from
+51 −62

Conversation

@shaedrich
Copy link
Contributor

@shaedrich shaedrich commented Oct 29, 2025 •
edited
Loading

Follow-up to #57564

As suggested in #57564 (comment)

Now all case-sensitive replacements use replaceWhileKeepingCase() method

The benefits from the original PR become even more valuable with this one:

✅ Improves readability by making the methods more compact without the "internal logic" in each of them
✅ Improves maintainability by having a single source of truth/failure
✅ Makes adapting this in new methods quite easy

@shaedrich shaedrich changed the title [12.x] Use ReplacesAttributes::replaceKeepCase() also for imploded parameters [12.x] Use ReplacesAttributes::replaceWhileKeepingCase() also for imploded parameters Oct 29, 2025
@shaedrich shaedrich marked this pull request as draft October 29, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shaedrich