fix: improve domain method to handle forcedRoot and return cleaned URL #105
+9
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: incorrect URLs when
forceRootis setWhen
forceRootwas used,Route::domain()returned the full root including the scheme. Sinceuri()prepends the scheme separately, this resulted in broken URLs likehttps://https//site.com/..., especially whenforceSchemewas also applied.This change makes
domain()return only the host part offorcedRoot(withouthttp://orhttps://). That way, combining it withscheme()produces a valid URL.This also fixes the issue reported in Issue #102