pass the full user object to findUsing callback #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this is a breaking change. If anyone is passing a custom callback for
findUsing
toauthenticate
, it will need to be updated.We are trying to support a hybrid login for an existing Laravel application where a subset of users (on a certain domain) use WorkOS, and the rest use the local login logic. We needed to customize
findUsing
to look up a user based on email, not just theworkos_id
, but we were unable to do it since the callback was only being passed the id.createUsing
andupdateUsing
deal with full user objects, so this also adds symmetry to thefindUsing
method.I'd normally add/update tests with a PR, but I don't see any tests. I'd be happy to build out test coverage, but that would be a separate PR.