breaking(sqlite): libsqlite3-sys
versioning, feature flags, safety changes
#3928
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to unreleased code (fold together with related PRs)
common.drivers.sqlite.load-extensions
todrivers.sqlite.unsafe-load-extensions
drivers.mysql
,drivers.postgres
, and support for future external driversBreaking Changes
libsqlite3-sys
versioning policy to use version rangesSqliteConnectOptions::extension()
and::extension_with_entrypoint()
asunsafe
sqlite-deserialize
enablingSqliteConnection::serialize()
andSqliteConnection::deserialize()
sqlite-load-extension
enablingSqliteConnectOptions::extension()
and::extension_with_entrypoint()
sqlite-unlock-notify
enables internal use ofsqlite3_unlock_notify()
SqliteValue
andSqliteValueRef
changes:sqlite3_value*
interface reserves the right to be stateful. Without protection, any call could theoretically invalidate values previously returned, leading to dangling pointers.SqliteValue
is now!Sync
andSqliteValueRef
is!Send
to prevent data races from concurrent accesses.SqliteValue
inMutex
, or convert theSqliteValueRef
to an owned value.SqliteValue
and any derivedSqliteValueRef
s now internally track if that value has been used to decode a borrowed&[u8]
or&str
and errors if it's used to decode any other type.SqliteValue
/SqliteValueRef
.SqliteValue
for details.TODO
sqlite3_value
is not safe to access concurrentlySqliteValue
drop internalMutex
andSqliteValue: Sync
, it's largely unnecessaryIssues
fixes #3926
fixes #3921
fixes #3905
Superceded PRs
closes #3927
closes #3922
closes #3888
closes #3844